jenkins-bot has submitted this change and it was merged. Change subject: Remove Persian from link underlining removal ......................................................................
Remove Persian from link underlining removal There was a discussion [1] on this on Persian Wikipedia and users don't want it actually. It is such an UI inconsistency and detecting links based on their color is hard. It may have problem on Amiri font but not on System default font and Persian Wikipedia fonts. [1] https://fa.wikipedia.org/wiki/MediaWiki:Common.css?oldid=10552148 Change-Id: I8168baff1b9e64d0c79dcd7a896b9cbeeed0b266 --- M includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php b/includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php index 7b4b668..bda8653 100644 --- a/includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php +++ b/includes/resourceloader/ResourceLoaderUserCSSPrefsModule.php @@ -71,7 +71,7 @@ ( $options['underline'] ? 'underline' : 'none' ) . "; }"; } else { # The scripts of these languages are very hard to read with underlines - $rules[] = 'a:lang(ar), a:lang(ckb), a:lang(fa),a:lang(kk-arab), ' . + $rules[] = 'a:lang(ar), a:lang(ckb), a:lang(kk-arab), ' . 'a:lang(mzn), a:lang(ps), a:lang(ur) { text-decoration: none; }'; } if ( $options['justify'] ) { -- To view, visit https://gerrit.wikimedia.org/r/75570 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8168baff1b9e64d0c79dcd7a896b9cbeeed0b266 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Ebrahim <[email protected]> Gerrit-Reviewer: Amire80 <[email protected]> Gerrit-Reviewer: Dalba <[email protected]> Gerrit-Reviewer: Ebrahim <[email protected]> Gerrit-Reviewer: Huji <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Ladsgroup <[email protected]> Gerrit-Reviewer: Matmarex <[email protected]> Gerrit-Reviewer: Nikerabbit <[email protected]> Gerrit-Reviewer: ZxxZxxZ <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
