Yuvipanda has uploaded a new change for review.
https://gerrit.wikimedia.org/r/76308
Change subject: Do not use underlines, ever.
......................................................................
Do not use underlines, ever.
Change-Id: Id83af650ef3392e9d45b578d06b500966de5e563
---
M src/template.txt
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/labs/tools/grrrit
refs/changes/08/76308/1
diff --git a/src/template.txt b/src/template.txt
index d5eefbe..c22db3f 100644
--- a/src/template.txt
+++ b/src/template.txt
@@ -2,13 +2,13 @@
{% if approvals -%}
[{%- for value in approvals -%}
{%- if value == "1" -%}
- {{loop.key}}: {{value|color('bold.green')}}{% if not loop.last
%} {% endif -%}
+ {{loop.key}}: {{value|color('green')}}{% if not loop.last %}
{% endif -%}
{%- else if value == "2" -%}
- {{loop.key}}: {{value|color('bold.underline.green')}}{% if not
loop.last %} {% endif -%}
+ {{loop.key}}: {{value|color('bold.green')}}{% if not loop.last
%} {% endif -%}
{%- else if value == "-1" -%}
- {{loop.key}}: {{value|color('bold.red')}}{% if not loop.last
%} {% endif -%}
+ {{loop.key}}: {{value|color('red')}}{% if not loop.last %} {%
endif -%}
{%- else -%}
- {{loop.key}}: {{value|color('bold.underline.red')}}{% if not
loop.last %} {% endif -%}
+ {{loop.key}}: {{value|color('bold.red')}}{% if not loop.last
%} {% endif -%}
{%- endif -%}
{%- endfor -%}]
{% endif %}
--
To view, visit https://gerrit.wikimedia.org/r/76308
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id83af650ef3392e9d45b578d06b500966de5e563
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/grrrit
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits