Spage has uploaded a new change for review.
https://gerrit.wikimedia.org/r/76471
Change subject: Try to use new Agora checkmark style in Login form
......................................................................
Try to use new Agora checkmark style in Login form
Gerrit 74662 (change Ia215c587) introduces a new style for checkboxes,
this work-in-progress tries to use it in Userlogin.
Change-Id: I1eb190f5d2206fe1729928091a0244cf8b6ed218
---
M includes/specials/SpecialUserlogin.php
M includes/templates/Userlogin.php
2 files changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/71/76471/1
diff --git a/includes/specials/SpecialUserlogin.php
b/includes/specials/SpecialUserlogin.php
index 6e557f3..7850959 100644
--- a/includes/specials/SpecialUserlogin.php
+++ b/includes/specials/SpecialUserlogin.php
@@ -1090,6 +1090,7 @@
'mediawiki.ui',
'mediawiki.special.userlogin'
) );
+ $out->addModules( 'mediawiki.ui.js' );
$q = 'action=submitlogin&type=login';
$linkq = 'type=signup';
diff --git a/includes/templates/Userlogin.php b/includes/templates/Userlogin.php
index b9825a6..3798794 100644
--- a/includes/templates/Userlogin.php
+++ b/includes/templates/Userlogin.php
@@ -140,8 +140,12 @@
<div>
<?php if ( $this->data['canremember'] ) { ?>
- <label class="mw-ui-checkbox-label">
- <input name="wpRemember" type="checkbox" value="1"
id="wpRemember" tabindex="4"
+ <!--
+ New Agora style of checkbox with image, see gerrit 74662.
+ Does the input field need a class? Does it need its own div to
get the box?
+ -->
+ <label class="mw-ui-styled-checkbox-label">
+ <input name="wpRemember" type="checkbox" value="1"
id="wpRemember" tabindex="4" class="mw-ui-checkbox"
<?php if ( $this->data['remember'] ) {
echo 'checked="checked"';
} ?>
@@ -153,7 +157,7 @@
<?php if ( $this->data['cansecurelogin'] ) { ?>
<div>
- <label class="mw-ui-checkbox-label">
+ <label class="mw-ui-styled-checkbox-label">
<input name="wpStickHTTPS" type="checkbox"
value="1" id="wpStickHTTPS" tabindex="5"
<?php if ( $this->data['stickHTTPS'] ) {
echo 'checked="checked"';
--
To view, visit https://gerrit.wikimedia.org/r/76471
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1eb190f5d2206fe1729928091a0244cf8b6ed218
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
