Cmcmahon has submitted this change and it was merged. Change subject: prevent flaky tests, wait for link to be present ......................................................................
prevent flaky tests, wait for link to be present Change-Id: Icd9bc6ea8116b95ca5d4aa443272b4f3827bc09b --- M features/step_definitions/preferences_appearance_steps.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Cmcmahon: Looks good to me, approved jenkins-bot: Verified diff --git a/features/step_definitions/preferences_appearance_steps.rb b/features/step_definitions/preferences_appearance_steps.rb index 0cdbab2..311e4bc 100644 --- a/features/step_definitions/preferences_appearance_steps.rb +++ b/features/step_definitions/preferences_appearance_steps.rb @@ -2,7 +2,7 @@ visit(PreferencesPage) end When(/^I click Appearance$/) do - visit(PreferencesPage).appearance_link + visit(PreferencesPage).appearance_link_element.when_present.click end Then(/^I can select skins$/) do on(PreferencesAppearancePage) do |page| -- To view, visit https://gerrit.wikimedia.org/r/76543 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd9bc6ea8116b95ca5d4aa443272b4f3827bc09b Gerrit-PatchSet: 1 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Cmcmahon <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
