jenkins-bot has submitted this change and it was merged.
Change subject: Unblacklist Opera >= 12
......................................................................
Unblacklist Opera >= 12
Opera 12 seems to work well enough, but I'm not confident enough to
whitelist it just yet.
Opera 15 is basically Chrome with a different interface, so it should
work perfectly, but it's barely out of beta and untested right now.
Bug: 36000
Change-Id: Ia80a6f53f8c128ef52d0bfde1828fdc132046afb
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
M modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
2 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
index b756f15..1b03afb 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
@@ -97,8 +97,9 @@
// Firefox issues in versions 12 and below (bug 50780)
// Wikilink [[./]] bug in Firefox 14 and below (bug
50720)
'firefox': [['<=', 14]],
+ // Opera < 12 was not tested and it's userbase is
almost nonexistent anyway
+ 'opera': [['<', 12]],
// Blacklist all versions:
- 'opera': null,
'blackberry': null
},
diff --git a/modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
b/modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
index 244a475..e9581e1 100644
--- a/modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
+++ b/modules/ve-mw/test/init/targets/ve.init.mw.ViewPageTarget.test.js
@@ -132,11 +132,16 @@
'matches': []
},
{
- 'msg': 'Opera',
- 'userAgent': 'Opera/12.80 (Windows NT 5.1; U;
en) Presto/2.10.289 Version/12.02',
+ 'msg': 'Opera 11',
+ 'userAgent': 'Opera/9.80 (Windows NT 5.1)
Presto/2.10.229 Version/11.64',
'matches': [ 'blacklist' ]
},
{
+ 'msg': 'Opera 12',
+ 'userAgent': 'Opera/9.80 (Windows NT 5.1)
Presto/2.12.388 Version/12.16',
+ 'matches': []
+ },
+ {
'msg': 'BlackBerry',
'userAgent': 'Mozilla/5.0 (BlackBerry; U;
BlackBerry 9900; en) AppleWebKit/534.11+ (KHTML, like Gecko) Version/7.1.0.346
Mobile Safari/534.11+',
'matches': [ 'blacklist' ]
--
To view, visit https://gerrit.wikimedia.org/r/72738
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia80a6f53f8c128ef52d0bfde1828fdc132046afb
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Matmarex <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: MZMcBride <[email protected]>
Gerrit-Reviewer: Matmarex <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
