Adamw has submitted this change and it was merged.
Change subject: Don't Create, Populate, or Protect CNBanner /qqq
......................................................................
Don't Create, Populate, or Protect CNBanner /qqq
qqq language messages are no longer automatically created, pre-populated
with en language, or edit/move protected.
Bug: 51478
Change-Id: I03bedd98911ad0f50007440711aab797eaf35d46
---
M includes/BannerMessage.php
1 file changed, 3 insertions(+), 7 deletions(-)
Approvals:
Adamw: Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/BannerMessage.php b/includes/BannerMessage.php
index 92e5341..4d65b4d 100644
--- a/includes/BannerMessage.php
+++ b/includes/BannerMessage.php
@@ -93,17 +93,13 @@
$savePage( $this->getTitle( $lang ), $translation );
- // If we're using translate : group review; create and protect
the english and QQQ pages
+ // If we're using translate : group review; create and protect
the english page
if ( $wgNoticeUseTranslateExtension
&& ( $lang === $wgLanguageCode )
&& BannerMessageGroup::isUsingGroupReview()
) {
$this->protectMessageInCnNamespaces(
$savePage( $this->getTitle( $lang, NS_CN_BANNER
), $translation ),
- $user
- );
- $this->protectMessageInCnNamespaces(
- $savePage( $this->getTitle( 'qqq', NS_CN_BANNER
), $translation ),
$user
);
}
@@ -114,8 +110,8 @@
* The protection lasts for infinity and acts for group
* @ref $wgNoticeProtectGroup
*
- * This really is intended only for use on the original source language
and qqq because
- * these languages are set via the CN UI; not the translate UI.
+ * This really is intended only for use on the original source language
+ * because those messages are set via the CN UI; not the translate UI.
*
* @param WikiPage $page Page containing the message to protect
* @param User $user User doing the protection (ie: the last one to
edit the page)
--
To view, visit https://gerrit.wikimedia.org/r/76639
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03bedd98911ad0f50007440711aab797eaf35d46
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Mwalker <[email protected]>
Gerrit-Reviewer: Adamw <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
