jenkins-bot has submitted this change and it was merged.
Change subject: (bug 52225) Some javascript and css fix for IE7
......................................................................
(bug 52225) Some javascript and css fix for IE7
1. clone() breaks the flyout layout in IE7
2. inline-block needs some adjustment for IE7
Change-Id: I014318aacb15000f132c4e4af74f5ea40a064712
---
M modules/overlay/ext.echo.overlay.css
M modules/overlay/ext.echo.overlay.js
2 files changed, 4 insertions(+), 2 deletions(-)
Approvals:
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/overlay/ext.echo.overlay.css
b/modules/overlay/ext.echo.overlay.css
index 651d0d2..bd51cc4 100644
--- a/modules/overlay/ext.echo.overlay.css
+++ b/modules/overlay/ext.echo.overlay.css
@@ -72,6 +72,8 @@
}
#mw-echo-overlay-title-text {
display: inline-block;
+ *display: inline;
+ zoom: 1;
}
#mw-echo-overlay-moreinfo-link {
display: inline-block;
diff --git a/modules/overlay/ext.echo.overlay.js
b/modules/overlay/ext.echo.overlay.js
index 3f91cf3..f03f5ca 100644
--- a/modules/overlay/ext.echo.overlay.js
+++ b/modules/overlay/ext.echo.overlay.js
@@ -200,8 +200,8 @@
// add link to notification preferences
$overlayFooter.append(
- $prefLink
- .clone()
+ $( '<a>' )
+ .html( $prefLink.html() )
.attr( 'id',
'mw-echo-overlay-pref-link' )
.addClass( 'mw-echo-grey-link' )
.attr( 'href', $prefLink.attr(
'href' ) + '#mw-prefsection-echo' )
--
To view, visit https://gerrit.wikimedia.org/r/76615
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I014318aacb15000f132c4e4af74f5ea40a064712
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bsitu <[email protected]>
Gerrit-Reviewer: EBernhardson (WMF) <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
