Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/76719
Change subject: Readability imporvements to FieldDefinitionTest
......................................................................
Readability imporvements to FieldDefinitionTest
Change-Id: Id8eac754d98adcc5a4bc6a9cf3d76187bf329d74
---
M tests/phpunit/FieldDefinitionTest.php
1 file changed, 20 insertions(+), 5 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseDatabase
refs/changes/19/76719/1
diff --git a/tests/phpunit/FieldDefinitionTest.php
b/tests/phpunit/FieldDefinitionTest.php
index 411c099..0cf78aa 100644
--- a/tests/phpunit/FieldDefinitionTest.php
+++ b/tests/phpunit/FieldDefinitionTest.php
@@ -24,23 +24,38 @@
$instances = array();
$instances[] = new FieldDefinition(
- 'names', FieldDefinition::TYPE_TEXT
+ 'names',
+ FieldDefinition::TYPE_TEXT
);
$instances[] = new FieldDefinition(
- 'numbers', FieldDefinition::TYPE_FLOAT
+ 'numbers',
+ FieldDefinition::TYPE_FLOAT
);
$instances[] = new FieldDefinition(
- 'stuffs', FieldDefinition::TYPE_INTEGER, false, 42,
FieldDefinition::ATTRIB_UNSIGNED
+ 'stuffs',
+ FieldDefinition::TYPE_INTEGER,
+ FieldDefinition::NOT_NULL,
+ 42,
+ FieldDefinition::ATTRIB_UNSIGNED
);
$instances[] = new FieldDefinition(
- 'stuffs', FieldDefinition::TYPE_INTEGER, true, null,
null
+ 'stuffs',
+ FieldDefinition::TYPE_INTEGER,
+ FieldDefinition::NULL,
+ FieldDefinition::NO_DEFAULT,
+ FieldDefinition::NO_ATTRIB
);
$instances[] = new FieldDefinition(
- 'stuffs', FieldDefinition::TYPE_INTEGER, true, null,
null, true
+ 'stuffs',
+ FieldDefinition::TYPE_INTEGER,
+ FieldDefinition::NULL,
+ FieldDefinition::NO_DEFAULT,
+ FieldDefinition::NO_ATTRIB,
+ FieldDefinition::AUTOINCREMENT
);
$argLists = array();
--
To view, visit https://gerrit.wikimedia.org/r/76719
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8eac754d98adcc5a4bc6a9cf3d76187bf329d74
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDatabase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
