Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/76720
Change subject: Match changes in WikibaseDatabase ...................................................................... Match changes in WikibaseDatabase This matches https://gerrit.wikimedia.org/r/#/c/76718/ Change-Id: I0c41f3f1fbd63ba0792a49254665990126652bc6 --- M src/SQLStore/Schema.php 1 file changed, 11 insertions(+), 18 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQueryEngine refs/changes/20/76720/1 diff --git a/src/SQLStore/Schema.php b/src/SQLStore/Schema.php index 06b8c59..c0127a0 100644 --- a/src/SQLStore/Schema.php +++ b/src/SQLStore/Schema.php @@ -174,13 +174,13 @@ } /** - * TODO - * * @since 0.1 * * @return FieldDefinition[] */ private function getPropertySnakFields() { + // TODO: indexes + return array( // Internal subject id new FieldDefinition( @@ -188,8 +188,7 @@ FieldDefinition::TYPE_INTEGER, FieldDefinition::NOT_NULL, FieldDefinition::NO_DEFAULT, - FieldDefinition::ATTRIB_UNSIGNED, - FieldDefinition::NO_INDEX + FieldDefinition::ATTRIB_UNSIGNED ), // Internal property id @@ -198,15 +197,12 @@ FieldDefinition::TYPE_INTEGER, FieldDefinition::NOT_NULL, FieldDefinition::NO_DEFAULT, - FieldDefinition::ATTRIB_UNSIGNED, - FieldDefinition::INDEX + FieldDefinition::ATTRIB_UNSIGNED ), ); } /** - * TODO - * * @since 0.1 * * @return TableDefinition[] @@ -232,6 +228,7 @@ * @return TableDefinition */ public function getEntitiesTable() { + // TODO: indexes return new TableDefinition( $this->config->getTablePrefix() . 'entities', array( @@ -241,8 +238,7 @@ FieldDefinition::TYPE_INTEGER, FieldDefinition::NOT_NULL, FieldDefinition::NO_DEFAULT, - FieldDefinition::ATTRIB_UNSIGNED, - FieldDefinition::INDEX + FieldDefinition::ATTRIB_UNSIGNED ), // EntityId type part @@ -251,8 +247,7 @@ FieldDefinition::TYPE_TEXT, FieldDefinition::NOT_NULL, FieldDefinition::NO_DEFAULT, - FieldDefinition::NO_ATTRIB, - FieldDefinition::INDEX + FieldDefinition::NO_ATTRIB ), // EntityId numerical part @@ -261,8 +256,7 @@ FieldDefinition::TYPE_INTEGER, FieldDefinition::NOT_NULL, FieldDefinition::NO_DEFAULT, - FieldDefinition::ATTRIB_UNSIGNED, - FieldDefinition::INDEX + FieldDefinition::ATTRIB_UNSIGNED ), ) ); @@ -274,6 +268,7 @@ * @return TableDefinition */ public function getValuelessSnaksTable() { + // TODO: indexes return new TableDefinition( $this->config->getTablePrefix() . 'valueless_snaks', array_merge( @@ -285,8 +280,7 @@ FieldDefinition::TYPE_INTEGER, FieldDefinition::NOT_NULL, FieldDefinition::NO_DEFAULT, - FieldDefinition::ATTRIB_UNSIGNED, - FieldDefinition::INDEX + FieldDefinition::ATTRIB_UNSIGNED ), // Role of the snak (ie "main snak" or "qualifier") @@ -295,8 +289,7 @@ FieldDefinition::TYPE_INTEGER, FieldDefinition::NOT_NULL, FieldDefinition::NO_DEFAULT, - FieldDefinition::ATTRIB_UNSIGNED, - FieldDefinition::INDEX + FieldDefinition::ATTRIB_UNSIGNED ), ) ) -- To view, visit https://gerrit.wikimedia.org/r/76720 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0c41f3f1fbd63ba0792a49254665990126652bc6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/WikibaseQueryEngine Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
