Ragesoss has uploaded a new change for review.
https://gerrit.wikimedia.org/r/76729
Change subject: Change variable name to fix pulldown prepopulation: bug 45506
......................................................................
Change variable name to fix pulldown prepopulation: bug 45506
Create a new variable name (instead $fieldFields being used twice)
so that the right values will be loaded for the pulldowns in the
edit course page interface.
Bug: 45506
Change-Id: I82988ddddd12c4f5643b1477d113e0144876bd8c
---
M includes/actions/EditCourseAction.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EducationProgram
refs/changes/29/76729/1
diff --git a/includes/actions/EditCourseAction.php
b/includes/actions/EditCourseAction.php
index 7d9424d..22f4ea8 100644
--- a/includes/actions/EditCourseAction.php
+++ b/includes/actions/EditCourseAction.php
@@ -211,13 +211,13 @@
},
);
- $fieldFields = $this->table->selectFields( 'term', array(),
array( 'DISTINCT' ) );
- $fieldFields = array_merge( array( '' => '' ), $fieldFields );
+ $fieldTerms = $this->table->selectFields( 'term', array(),
array( 'DISTINCT' ) );
+ $fieldTerms = array_merge( array( '' => '' ), $fieldTerms );
$fields['term'] = array(
'class' => 'EducationProgram\HTMLCombobox',
'label-message' => 'ep-course-edit-term',
'required' => true,
- 'options' => array_combine( $fieldFields, $fieldFields
),
+ 'options' => array_combine( $fieldTerms, $fieldTerms ),
);
$fields['start'] = array(
--
To view, visit https://gerrit.wikimedia.org/r/76729
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82988ddddd12c4f5643b1477d113e0144876bd8c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EducationProgram
Gerrit-Branch: master
Gerrit-Owner: Ragesoss <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
