Dzahn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/76831


Change subject: let misc::maintenance::updatequerypages use $enabled like the 
other maintenance jobs, avoid puppet breakage due to Invalid parameter enabled 
when trying to use $enabled in site.pp
......................................................................

let misc::maintenance::updatequerypages use $enabled like the other
maintenance jobs, avoid puppet breakage due to Invalid parameter enabled
when trying to use $enabled in site.pp

Change-Id: I1f1a53e6ace25e8bb511a3b04311e7b28890cb8b
---
M manifests/misc/maintenance.pp
1 file changed, 6 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/31/76831/1

diff --git a/manifests/misc/maintenance.pp b/manifests/misc/maintenance.pp
index 7fce450..021d23e 100644
--- a/manifests/misc/maintenance.pp
+++ b/manifests/misc/maintenance.pp
@@ -394,7 +394,7 @@
 
 }
 
-class misc::maintenance::updatequerypages {
+class misc::maintenance::updatequerypages( $enabled = false ) {
         # Include this to add cron jobs calling updateSpecialPages.php on all 
clusters.
 
         file { '/home/mwdeploy/updateSpecialPages':
@@ -414,7 +414,11 @@
                         hour => 1,
                         minute => 0,
                         monthday => $monthday,
-                        ensure => present,
+                        ensure => $enabled ?{
+                          true => present,
+                          false => absent,
+                          default => absent
+                        };
                 }
 
                 cron { "cron-updatequerypages-ancientpages-${name}":

-- 
To view, visit https://gerrit.wikimedia.org/r/76831
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f1a53e6ace25e8bb511a3b04311e7b28890cb8b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to