Mwalker has submitted this change and it was merged.
Change subject: Prevent banner display in print media
......................................................................
Prevent banner display in print media
Change-Id: I458b5fabb93a79fd89f59296831841b43568cced
---
M CentralNotice.php
A modules/ext.centralNotice.bannerController/bannerController.css
2 files changed, 9 insertions(+), 3 deletions(-)
Approvals:
Mwalker: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CentralNotice.php b/CentralNotice.php
index 17416b6..497d26a 100644
--- a/CentralNotice.php
+++ b/CentralNotice.php
@@ -135,9 +135,10 @@
'scripts' => 'ext.centralNotice.bannerStats/bannerStats.js',
);
$wgResourceModules[ 'ext.centralNotice.bannerController' ] = array(
- 'localBasePath' => $dir . '/modules',
- 'remoteExtPath' => 'CentralNotice/modules',
- 'scripts' =>
'ext.centralNotice.bannerController/bannerController.js',
+ 'localBasePath' => $dir . '/modules/ext.centralNotice.bannerController',
+ 'remoteExtPath' =>
'CentralNotice/modules/ext.centralNotice.bannerController',
+ 'styles' => 'bannerController.css',
+ 'scripts' => 'bannerController.js',
'position' => 'top',
'dependencies' => array(
'jquery.cookie',
diff --git a/modules/ext.centralNotice.bannerController/bannerController.css
b/modules/ext.centralNotice.bannerController/bannerController.css
new file mode 100644
index 0000000..300f96b
--- /dev/null
+++ b/modules/ext.centralNotice.bannerController/bannerController.css
@@ -0,0 +1,5 @@
+@media print {
+ #centralNotice {
+ display: none;
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/76863
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I458b5fabb93a79fd89f59296831841b43568cced
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Adamw <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
