jenkins-bot has submitted this change and it was merged.
Change subject: Stop producing nonsense words in suggestions.
......................................................................
Stop producing nonsense words in suggestions.
Did this by using an analysis chain closer to the default for
suggestions so we wouldn't suggest stemmed words. This should work fine
for space delimited languages but will need some love when we turn to
non-space delimited languages.
Change-Id: I59252615964def7e3330a4b95bcd3189f53497ea
---
M updateSearchConfig.php
1 file changed, 26 insertions(+), 6 deletions(-)
Approvals:
Demon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/updateSearchConfig.php b/updateSearchConfig.php
index 553f966..808d5f0 100644
--- a/updateSearchConfig.php
+++ b/updateSearchConfig.php
@@ -312,9 +312,7 @@
'analysis' => array(
'analyzer' => array(
'text' => $this->buildTextAnalyzer(),
- 'suggest' => array_merge(
$this->buildTextAnalyzer(), array(
- 'filter' => array(
'suggest_shingle' )
- ) ),
+ 'suggest' =>
$this->buildSuggestAnalyzer(),
'prefix' => array(
'type' => 'custom',
'tokenizer' => 'prefix',
@@ -347,13 +345,35 @@
);
}
+ /**
+ * Build a suggest analyzer customized for this language code.
+ */
private function buildTextAnalyzer() {
+ $langs = Language::getTranslatedLanguageNames( 'en' );
+ $analyzer = array(
+ 'type' => strtolower( $langs["en"] ),
+ );
+
global $wgLanguageCode;
switch ($wgLanguageCode) {
- case 'en': return array(
- 'type' => 'english'
- );
+ // Customization goes here.
}
+
+ return $analyzer;
+ }
+
+ private function buildSuggestAnalyzer() {
+ $analyzer = array(
+ 'type' => 'default',
+ 'filter' => array( 'suggest_shingle' ),
+ );
+
+ global $wgLanguageCode;
+ switch ($wgLanguageCode) {
+ // Customization goes here.
+ }
+
+ return $analyzer;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/76832
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59252615964def7e3330a4b95bcd3189f53497ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Manybubbles <[email protected]>
Gerrit-Reviewer: Demon <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
