Daniel Kinzler has submitted this change and it was merged.
Change subject: Fixed tests to work properly with changed WebClientRecommender
......................................................................
Fixed tests to work properly with changed WebClientRecommender
Change-Id: I7c8206b23a4e3d2e60dab2f2b5610d01d9efa032
---
M
client/src/test/java/org/wikimedia/wikibase/entitysuggester/client/recommender/WebClientRecommenderTest.java
M
client/src/test/java/org/wikimedia/wikibase/entitysuggester/client/servlets/AbstractEntitySuggesterServletTest.java
2 files changed, 6 insertions(+), 4 deletions(-)
Approvals:
Daniel Kinzler: Verified; Looks good to me, approved
diff --git
a/client/src/test/java/org/wikimedia/wikibase/entitysuggester/client/recommender/WebClientRecommenderTest.java
b/client/src/test/java/org/wikimedia/wikibase/entitysuggester/client/recommender/WebClientRecommenderTest.java
index 5541293..7964843 100644
---
a/client/src/test/java/org/wikimedia/wikibase/entitysuggester/client/recommender/WebClientRecommenderTest.java
+++
b/client/src/test/java/org/wikimedia/wikibase/entitysuggester/client/recommender/WebClientRecommenderTest.java
@@ -55,7 +55,8 @@
ArrayList<String> propertyIDList = new ArrayList<String>();
propertyIDList.add("P67");
propertyIDList.add("P192");
- AbstractClientRecommender webClientRecommender = new
WebClientRecommender(propertyIDList, translatingRecommender);
+ translatingRecommender.addItemIDs(propertyIDList);
+ AbstractClientRecommender webClientRecommender = new
WebClientRecommender(translatingRecommender);
// Test with a wikibaseItem that is in the Myrrix model
List<TranslatedRecommendedItem> suggestions =
webClientRecommender.recommend("Q87", 10);
@@ -72,7 +73,8 @@
ArrayList<String> propertyIDList = new ArrayList<String>();
propertyIDList.add("P67");
propertyIDList.add("P192");
- AbstractClientRecommender webClientRecommender = new
WebClientRecommender(propertyIDList, translatingRecommender);
+ translatingRecommender.addItemIDs(propertyIDList);
+ AbstractClientRecommender webClientRecommender = new
WebClientRecommender(translatingRecommender);
List<TranslatedRecommendedItem> suggestions =
webClientRecommender.recommendAnonymous(new String[]{"P67", "P78"}, 2);
assertEquals("P67", suggestions.get(0).getItemID());
diff --git
a/client/src/test/java/org/wikimedia/wikibase/entitysuggester/client/servlets/AbstractEntitySuggesterServletTest.java
b/client/src/test/java/org/wikimedia/wikibase/entitysuggester/client/servlets/AbstractEntitySuggesterServletTest.java
index 34916b6..ae195e2 100644
---
a/client/src/test/java/org/wikimedia/wikibase/entitysuggester/client/servlets/AbstractEntitySuggesterServletTest.java
+++
b/client/src/test/java/org/wikimedia/wikibase/entitysuggester/client/servlets/AbstractEntitySuggesterServletTest.java
@@ -65,11 +65,11 @@
ArrayList<String> propertyIDList = new ArrayList<String>();
propertyIDList.add("P67");
propertyIDList.add("P192");
- WebClientRecommender webClientRecommender = new
WebClientRecommender(propertyIDList, translatingRecommender);
+ translatingRecommender.addItemIDs(propertyIDList);
+ WebClientRecommender webClientRecommender = new
WebClientRecommender(translatingRecommender);
servlet.getServletConfig().getServletContext().setAttribute("recommender",
webClientRecommender);;
MockHttpServletRequest mockHttpServletRequest = new
MockHttpServletRequest();
- servlet.initializeClientRecommender(mockHttpServletRequest);
WebClientRecommender fromServlet = servlet.getClientRecommender();
List<TranslatedRecommendedItem> suggestions =
webClientRecommender.recommend("Q87", 10);
--
To view, visit https://gerrit.wikimedia.org/r/76878
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c8206b23a4e3d2e60dab2f2b5610d01d9efa032
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/WikidataEntitySuggester
Gerrit-Branch: master
Gerrit-Owner: Nilesh <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Nilesh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
