Mwalker has uploaded a new change for review.
https://gerrit.wikimedia.org/r/77057
Change subject: (FR #953) Do not expand banner message in edit box
......................................................................
(FR #953) Do not expand banner message in edit box
Per the card we will no longer expand the message whilst editing it
thus preserving the template/wikitext data in the message field.
Change-Id: I2699da53f3d60e61e70458155f8bb1fb3207b8ab
---
M includes/BannerMessage.php
M includes/HtmlFormElements/HTMLCentralNoticeBannerMessage.php
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/57/77057/1
diff --git a/includes/BannerMessage.php b/includes/BannerMessage.php
index 4d65b4d..277be8b 100644
--- a/includes/BannerMessage.php
+++ b/includes/BannerMessage.php
@@ -52,7 +52,7 @@
function getContents( $lang ) {
if ( $this->existsInLang( $lang ) ) {
$dbKey = $this->getDbKey();
- $msg = wfMessage( $dbKey )->inLanguage( $lang )->text();
+ $msg = Revision::newFromTitle( $this->getTitle( $lang )
)->getContent()->getNativeData();
if ( $msg === "<{$dbKey}>" ) {
$msg = '';
}
diff --git a/includes/HtmlFormElements/HTMLCentralNoticeBannerMessage.php
b/includes/HtmlFormElements/HTMLCentralNoticeBannerMessage.php
index 578642a..518ead7 100644
--- a/includes/HtmlFormElements/HTMLCentralNoticeBannerMessage.php
+++ b/includes/HtmlFormElements/HTMLCentralNoticeBannerMessage.php
@@ -43,10 +43,10 @@
parent::__construct( $params );
}
- /** Empty - no validation can be done on a banner */
+ /** Empty - no validation can be done on a banner message */
function validate( $value, $alldata ) { return true; }
- /** Get a preview of the banner */
+ /** Get a preview of the banner message */
public function getInputHTML( $value ) {
global $wgContLang;
--
To view, visit https://gerrit.wikimedia.org/r/77057
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2699da53f3d60e61e70458155f8bb1fb3207b8ab
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Mwalker <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
