Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/77253
Change subject: Fix pageExists/isViewPage behaviour
......................................................................
Fix pageExists/isViewPage behaviour
"Let me clarify this for you" - Timo
Bug: 49000
Change-Id: Ia094aa9aae1da1ba11dbaef827e305cbcf08f9b4
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/53/77253/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
index eafd735..ec2760c 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.init.js
@@ -53,13 +53,12 @@
conf = mw.config.get( 'wgVisualEditorConfig' );
uri = new mw.Uri();
- // For non-article pages, no information about page existence is
exposed to
+ // For special pages, no information about page existence is exposed to
// mw.config, so we assume it exists TODO: fix this in core.
- pageExists = !!mw.config.get( 'wgArticleId' ) || !mw.config.get(
'wgIsArticle' );
+ pageExists = !!mw.config.get( 'wgArticleId' ) || mw.config.get(
'wgNamespaceNumber' ) < 0;
viewUri = new mw.Uri( mw.util.wikiGetlink( mw.config.get(
'wgRelevantPageName' ) ) );
veEditUri = viewUri.clone().extend( { 'veaction': 'edit' } );
isViewPage = (
- mw.config.get( 'wgAction' ) === 'view' &&
mw.config.get( 'wgIsArticle' ) &&
!( 'diff' in uri.query )
);
--
To view, visit https://gerrit.wikimedia.org/r/77253
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia094aa9aae1da1ba11dbaef827e305cbcf08f9b4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
