Trevor Parscal has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/77264


Change subject: Don't override link target input value while typing
......................................................................

Don't override link target input value while typing

In some cases this would make VisualEditor be way too aggressive in forcing you 
into the first matching page.

Change-Id: Ie0a793853d884ee0abf490a99c5214082e9dbf27
---
M modules/ve-mw/ui/widgets/ve.ui.MWLinkTargetInputWidget.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/64/77264/1

diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWLinkTargetInputWidget.js 
b/modules/ve-mw/ui/widgets/ve.ui.MWLinkTargetInputWidget.js
index cd42942..30eac64 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWLinkTargetInputWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWLinkTargetInputWidget.js
@@ -155,7 +155,8 @@
        // Update annotation to match selected item
        item = this.lookupMenu.getSelectedItem();
        if ( item ) {
-               this.setAnnotation( item.getData() );
+               // Set annotation directly, bypassing re-setting the value of 
the input
+               this.annotation = item.getData();
        }
 };
 

-- 
To view, visit https://gerrit.wikimedia.org/r/77264
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0a793853d884ee0abf490a99c5214082e9dbf27
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to