ArielGlenn has uploaded a new change for review. https://gerrit.wikimedia.org/r/77330
Change subject: rewrite of admins.pp, changes how accounts are enabled/disabled, bug fixes ...................................................................... rewrite of admins.pp, changes how accounts are enabled/disabled, bug fixes *split into groups.pp, admins.pp, accounts.pp, renamed classes accordingly *some accounts had been marked as disabled but puppet did not remove them because of missing params; to disable an account you now just add the name to a list *home dirs of disabled accounts with managed home weren't removed (puppet bug 10354), now manually remove those *ssh key removal fails if the user is missing so don't do that; if not managedhome, remove authorized keys file on acct disable *removing a user from an admin:xxx list now removes them from the host where it was declared, if they are not in some other admin:: list on that host *removing all admin::xxx lists from a host removes all user accounts *defaults for most user and ssh_key attributes set, no need to pass them in *dynamic scope warnings about gid are fixed, no class inheritance used *nfs::home is not used anymore and nothing broke so removed the check *various style fixes, removal of old cruft, reordering, etc. Issues not addressed: *Keys added by user to ssh_authorized_keys and unknown to puppet will be left there (and purging doesn't work, see puppet bug 1581) *Groups created during account creation are never removed *No easy way to ad a list of users to a secondary group *If puppet is broken or disabled on a host, it will not get account changes, in particular account purges *Puppet issue 21203 can cause ssh key creation to randomly fail, a rerun should 'fix' it Change-Id: Ifb95872a2183d60d3015d3ab7b565166c585dc72 --- A manifests/accounts.pp M manifests/admins.pp M manifests/base.pp A manifests/groups.pp M manifests/misc/fundraising.pp M manifests/role/analytics.pp M manifests/role/fundraising.pp M manifests/role/logging.pp M manifests/site.pp 9 files changed, 2,499 insertions(+), 3,287 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/30/77330/1 -- To view, visit https://gerrit.wikimedia.org/r/77330 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifb95872a2183d60d3015d3ab7b565166c585dc72 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: ArielGlenn <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
