Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/77343


Change subject: Remove notices that have been there for 8 months, being totally 
not helpfull
......................................................................

Remove notices that have been there for 8 months, being totally not helpfull

TODOs will also keep track of it, and clearly the notices are not
promting anyone to take care of the lack of tests for this code.

Change-Id: Ia2131a6d3fd83412af0b88d608b6b60cafb74b57
---
M lib/tests/phpunit/ChangeNotificationJobTest.php
1 file changed, 3 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/43/77343/1

diff --git a/lib/tests/phpunit/ChangeNotificationJobTest.php 
b/lib/tests/phpunit/ChangeNotificationJobTest.php
index cbf8347..03bdd41 100644
--- a/lib/tests/phpunit/ChangeNotificationJobTest.php
+++ b/lib/tests/phpunit/ChangeNotificationJobTest.php
@@ -20,17 +20,9 @@
  */
 class ChangeNotificationJobTest extends \MediaWikiTestCase {
 
-       public function testNewFromChanges() {
-               $this->markTestIncomplete( "not yet implemented" );
-       }
-
-       public function testGetChanges() {
-               $this->markTestIncomplete( "not yet implemented" );
-       }
-
-       public function testRun() {
-               $this->markTestIncomplete( "not yet implemented" );
-       }
+       // TODO: testNewFromChanges
+       // TODO: testGetChanges
+       // TODO: testRun
 
        public static function provideToString() {
                $change1 = \Wikibase\ChangesTable::singleton()->newRow( array(

-- 
To view, visit https://gerrit.wikimedia.org/r/77343
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2131a6d3fd83412af0b88d608b6b60cafb74b57
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to