Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/77346
Change subject: Only skip past empty keyedNodes sets if key exists
......................................................................
Only skip past empty keyedNodes sets if key exists
Otherwise unkeyed references won't be listed!
Bug: 52427
Change-Id: I8bbce955f584cca046e23d07aab8440f1e733657
---
M modules/ve-mw/ce/nodes/ve.ce.MWReferenceListNode.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/46/77346/1
diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWReferenceListNode.js
b/modules/ve-mw/ce/nodes/ve.ce.MWReferenceListNode.js
index 0c7b908..0f3ca0b 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWReferenceListNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWReferenceListNode.js
@@ -162,7 +162,7 @@
return true;
} );
- if ( !keyedNodes.length ) {
+ if ( key !== undefined && !keyedNodes.length ) {
continue;
}
--
To view, visit https://gerrit.wikimedia.org/r/77346
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bbce955f584cca046e23d07aab8440f1e733657
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
