Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/77486
Change subject: Filter out elements that are not :visible when attaching.
......................................................................
Filter out elements that are not :visible when attaching.
Thus, if the only candidate(s) are non-:visible elements, it will
fallback to the center, as with entirely missing elements.
Non-:visible elements are not handled by jQuery offset, so
_getAttachCss returns meaningless values (e.g. (0, 0)) for them.
Change-Id: Ic862e14022ae6e1b21b1241c36a619b398a8eccf
---
M modules/mediawiki.libs.guiders/mediawiki.libs.guiders.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GuidedTour
refs/changes/86/77486/1
diff --git a/modules/mediawiki.libs.guiders/mediawiki.libs.guiders.js
b/modules/mediawiki.libs.guiders/mediawiki.libs.guiders.js
index 9da4f8a..ccc0a5a 100644
--- a/modules/mediawiki.libs.guiders/mediawiki.libs.guiders.js
+++ b/modules/mediawiki.libs.guiders/mediawiki.libs.guiders.js
@@ -443,7 +443,10 @@
// However, the DOM or window size may change later, and on each attach we
want to start
// with the originally requested position as the baseline.
- var attachTo = $(myGuider.attachTo);
+ // Elements that are not :visible (such as those with display: none)
+ // will return incorrect values from _getAttachCss, since jQuery offset
does not
+ // support such elements.
+ var attachTo = $(myGuider.attachTo).filter(':visible');
position = attachTo.length > 0 ? myGuider.position : 0;
var css = guiders._getAttachCss(attachTo, myGuider, position);
--
To view, visit https://gerrit.wikimedia.org/r/77486
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic862e14022ae6e1b21b1241c36a619b398a8eccf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GuidedTour
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
