Rfaulk has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/77512


Change subject: fix. properly handle response using brokers.
......................................................................

fix. properly handle response using brokers.

Change-Id: I25c7dbc55c88ca6a9f0b3dee47b53196b78bfaae
---
M user_metrics/api/engine/response_handler.py
1 file changed, 6 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/analytics/user-metrics 
refs/changes/12/77512/1

diff --git a/user_metrics/api/engine/response_handler.py 
b/user_metrics/api/engine/response_handler.py
index 1afe605..296eaea 100644
--- a/user_metrics/api/engine/response_handler.py
+++ b/user_metrics/api/engine/response_handler.py
@@ -10,7 +10,8 @@
 
 from user_metrics.api import RESPONSE_BROKER_TARGET, umapi_broker_context
 from user_metrics.config import logging
-from user_metrics.api.engine.request_meta import rebuild_unpacked_request
+from user_metrics.api.engine import unpack_response_for_broker
+from user_metrics.api.engine.request_meta import build_request_obj
 from user_metrics.api.engine.data import set_data, build_key_signature
 
 import time
@@ -40,16 +41,14 @@
         if not res_item:
             continue
 
-        request_meta = rebuild_unpacked_request(res_item)
-        key_sig = build_key_signature(request_meta, hash_result=True)
+        request, data = unpack_response_for_broker(res_item)
+        request_obj = build_request_obj(request)
 
         # Add result to cache once completed
         # TODO - umapi_broker_context.add(target, key_sig, res_item)
 
         logging.debug(log_name + ' - Setting data for {0}'.format(
-            str(request_meta)))
-        set_data(stream, request_meta)
-
-
+            str(request_obj)))
+        set_data(data, request_obj)
 
     logging.debug(log_name + ' - SHUTTING DOWN...')

-- 
To view, visit https://gerrit.wikimedia.org/r/77512
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I25c7dbc55c88ca6a9f0b3dee47b53196b78bfaae
Gerrit-PatchSet: 1
Gerrit-Project: analytics/user-metrics
Gerrit-Branch: repair_runtime
Gerrit-Owner: Rfaulk <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to