Yuvipanda has submitted this change and it was merged. Change subject: template: Remove underline from emphasis (only colour and bold) ......................................................................
template: Remove underline from emphasis (only colour and bold) Underlines make it a bit too crowded in my opinion. Change-Id: If350f482594786be283e16bd61d551ecd3b254f8 GitHub: https://github.com/wikimedia/labs-tools-grrrit/pull/3 --- M src/template.txt 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Yuvipanda: Looks good to me, approved AzaToth: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/src/template.txt b/src/template.txt index d5eefbe..c22db3f 100644 --- a/src/template.txt +++ b/src/template.txt @@ -2,13 +2,13 @@ {% if approvals -%} [{%- for value in approvals -%} {%- if value == "1" -%} - {{loop.key}}: {{value|color('bold.green')}}{% if not loop.last %} {% endif -%} + {{loop.key}}: {{value|color('green')}}{% if not loop.last %} {% endif -%} {%- else if value == "2" -%} - {{loop.key}}: {{value|color('bold.underline.green')}}{% if not loop.last %} {% endif -%} + {{loop.key}}: {{value|color('bold.green')}}{% if not loop.last %} {% endif -%} {%- else if value == "-1" -%} - {{loop.key}}: {{value|color('bold.red')}}{% if not loop.last %} {% endif -%} + {{loop.key}}: {{value|color('red')}}{% if not loop.last %} {% endif -%} {%- else -%} - {{loop.key}}: {{value|color('bold.underline.red')}}{% if not loop.last %} {% endif -%} + {{loop.key}}: {{value|color('bold.red')}}{% if not loop.last %} {% endif -%} {%- endif -%} {%- endfor -%}] {% endif %} -- To view, visit https://gerrit.wikimedia.org/r/77566 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If350f482594786be283e16bd61d551ecd3b254f8 Gerrit-PatchSet: 1 Gerrit-Project: labs/tools/grrrit Gerrit-Branch: master Gerrit-Owner: SuchABot <[email protected]> Gerrit-Reviewer: AzaToth <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Yuvipanda <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
