[MediaWiki-commits] [Gerrit] Tone down the Java hate a little - change (apps...commons)

[Yuvipanda (Code Review)]

Yuvipanda has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/77568


Change subject: Tone down the Java hate a little
......................................................................

Tone down the Java hate a little

Change-Id: Ib1efbce3df6c136c423a566535c1b064a1c77b1b
---
M commons/src/main/java/org/wikimedia/commons/upload/MultipleShareActivity.java
M commons/src/main/java/org/wikimedia/commons/upload/ShareActivity.java
M commons/src/main/java/org/wikimedia/commons/upload/UploadController.java
3 files changed, 0 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/commons 
refs/changes/68/77568/1

diff --git 
a/commons/src/main/java/org/wikimedia/commons/upload/MultipleShareActivity.java 
b/commons/src/main/java/org/wikimedia/commons/upload/MultipleShareActivity.java
index 44e6a78..57bdab1 100644
--- 
a/commons/src/main/java/org/wikimedia/commons/upload/MultipleShareActivity.java
+++ 
b/commons/src/main/java/org/wikimedia/commons/upload/MultipleShareActivity.java
@@ -88,10 +88,6 @@
                         startingToast.show();
                     }
                 }
-
-                public boolean isJavaAPieceOfShit() {
-                    return true;
-                }
             });
         }
 
diff --git 
a/commons/src/main/java/org/wikimedia/commons/upload/ShareActivity.java 
b/commons/src/main/java/org/wikimedia/commons/upload/ShareActivity.java
index 4010ad3..983018f 100644
--- a/commons/src/main/java/org/wikimedia/commons/upload/ShareActivity.java
+++ b/commons/src/main/java/org/wikimedia/commons/upload/ShareActivity.java
@@ -54,10 +54,6 @@
                 ShareActivity.this.contribution = contribution;
                 showPostUpload();
             }
-
-            public boolean isJavaAPieceOfShit() {
-                return true;
-            }
         });
     }
 
diff --git 
a/commons/src/main/java/org/wikimedia/commons/upload/UploadController.java 
b/commons/src/main/java/org/wikimedia/commons/upload/UploadController.java
index 84f6549..00c9a41 100644
--- a/commons/src/main/java/org/wikimedia/commons/upload/UploadController.java
+++ b/commons/src/main/java/org/wikimedia/commons/upload/UploadController.java
@@ -31,7 +31,6 @@
 
     public interface ContributionUploadProgress {
         void onUploadStarted(Contribution contribution);
-        boolean isJavaAPieceOfShit();
     }
 
     public UploadController(Activity activity) {
@@ -153,7 +152,6 @@
             protected void onPostExecute(Contribution contribution) {
                 super.onPostExecute(contribution);
                 uploadService.queue(UploadService.ACTION_UPLOAD_FILE, 
contribution);
-                assert onComplete.isJavaAPieceOfShit();
                 onComplete.onUploadStarted(contribution);
             }
         });

-- 
To view, visit https://gerrit.wikimedia.org/r/77568
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1efbce3df6c136c423a566535c1b064a1c77b1b
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/commons
Gerrit-Branch: campaigns
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits