Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/77649
Change subject: Refactor complex ternary operation
......................................................................
Refactor complex ternary operation
Change-Id: I1b6cc1cf0348bc7e19f9f327c7a3d6d936cfaaf2
---
M data/LanguageNameSearch.php
1 file changed, 11 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/49/77649/1
diff --git a/data/LanguageNameSearch.php b/data/LanguageNameSearch.php
index 3aa5e7b..b2b196f 100644
--- a/data/LanguageNameSearch.php
+++ b/data/LanguageNameSearch.php
@@ -84,10 +84,20 @@
// 224 is the lowest
non-overlong-encoded codepoint.
$lookingFor = ( $thisValue < 224 ) ? 2
: 3;
}
+
$values[] = $thisValue;
if ( count( $values ) === $lookingFor ) {
// Refer
http://en.wikipedia.org/wiki/UTF-8#Description
- $number = ( $lookingFor === 3 ) ? ( (
$values[0] % 16 ) * 4096 ) + ( ( $values[1] % 64 ) * 64 ) + ( $values[2] % 64 )
: ( ( $values[0] % 32 ) * 64 ) + ( $values[1] % 64 );
+ $number = $values[2] % 64;
+
+ if ( $lookingFor === 3 ) {
+ $number += ( $values[0] % 16 )
* 4096;
+ $number += ( $values[1] % 64 )
* 64;
+
+ } else {
+ $number += ( $values[0] % 32 )
* 64;
+
+ }
return $number;
}
--
To view, visit https://gerrit.wikimedia.org/r/77649
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b6cc1cf0348bc7e19f9f327c7a3d6d936cfaaf2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
