Siebrand has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/77690


Change subject: Update documentation
......................................................................

Update documentation

Change-Id: Ibf5757a9fa287fc3dc6c72af9147a691957225a6
---
M rebuild.php
1 file changed, 9 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/cldr 
refs/changes/90/77690/1

diff --git a/rebuild.php b/rebuild.php
index 37cab06..3fdbb85 100644
--- a/rebuild.php
+++ b/rebuild.php
@@ -179,8 +179,8 @@
 
        /**
         * Parse method for the file structure found in 
common/supplemental/supplementalData.xml
-        * @param type $inputFile
-        * @param type $outputFile
+        * @param string $inputFile
+        * @param string $outputFile
         */
        function parse_supplemental( $inputFile, $outputFile ) {
                // Open the input file for reading
@@ -229,11 +229,10 @@
         * This is separate from the regular parse function, because we need 
all of
         * the currency locale information, even if mediawiki doesn't support 
the language.
         * (For instance: en_AU uses '$' for AUD, not USD, but it's not a 
supported mediawiki locality)
-        * @param type $inputDir - the directory, in which we will parse 
everything.
-        * @param type $outputFile
+        * @param string $inputDir - the directory, in which we will parse 
everything.
+        * @param string $outputFile
         */
        function parse_currency_symbols( $inputDir, $outputFile ) {
-
                if ( file_exists( $inputDir ) ) {
                        $files = scandir( $inputDir );
                }
@@ -283,7 +282,6 @@
                 * From narrowest scope to widest, collapse the defaults
                 */
                foreach ( $data['currencySymbols'] as $currency => $language ) {
-
                        //get the currency default symbol. This will either be 
defined in the
                        // 'root' language file, or taken from the ISO code.
                        $default = $currency;
@@ -304,8 +302,10 @@
                                        }
                                }
                        }
+
                        ksort( $data['currencySymbols'][$currency] );
                }
+
                ksort( $data['currencySymbols'] );
 
                $this->savephp( $data, $outputFile );
@@ -348,8 +348,9 @@
 
        /**
         * It makes pretty array vals. Dur.
-        * @param type $thing
-        * @param type $level
+        * @param string $key
+        * @param string $value
+        * @param int $level
         * @return string
         */
        function makePrettyArrayOuts( $key, $value, $level = 1 ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/77690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf5757a9fa287fc3dc6c72af9147a691957225a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/cldr
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to