jenkins-bot has submitted this change and it was merged.
Change subject: Refactor getCodepoint() to more consistently handle return
values
......................................................................
Refactor getCodepoint() to more consistently handle return values
Change-Id: Ida90e6c78be41e8527eaefd14feb45c57413945e
---
M data/LanguageNameSearch.php
1 file changed, 10 insertions(+), 3 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/data/LanguageNameSearch.php b/data/LanguageNameSearch.php
index bd8a519..da1c76b 100644
--- a/data/LanguageNameSearch.php
+++ b/data/LanguageNameSearch.php
@@ -75,11 +75,16 @@
$values = array();
$lookingFor = 1;
$strLen = strlen( $str );
+ $number = 0;
+
for ( $i = 0; $i < $strLen; $i++ ) {
$thisValue = ord( $str[$i] );
if ( $thisValue < 128 ) {
- return $thisValue;
- } else { // Codepoints larger than 127 are represented
by multi-byte sequences
+ $number = $thisValue;
+
+ break;
+ } else {
+ // Codepoints larger than 127 are represented
by multi-byte sequences
if ( count( $values ) === 0 ) {
// 224 is the lowest
non-overlong-encoded codepoint.
$lookingFor = ( $thisValue < 224 ) ? 2
: 3;
@@ -97,10 +102,12 @@
$number += $values[1] % 64;
}
- return $number;
+ break;
}
}
}
+
+ return $number;
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/77650
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida90e6c78be41e8527eaefd14feb45c57413945e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
