Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/77894
Change subject: Remove logins that are not needed
......................................................................
Remove logins that are not needed
As we now login on setup of the base we no longer
need to log in when running all of these smaller
tests
Change-Id: I198a2052f3de5b6a286ae166ea692795e996bc76
---
M repo/tests/phpunit/includes/api/EditEntityTest.php
M repo/tests/phpunit/includes/api/EditPageTest.php
2 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/94/77894/1
diff --git a/repo/tests/phpunit/includes/api/EditEntityTest.php
b/repo/tests/phpunit/includes/api/EditEntityTest.php
index 60bc354..cccb68f 100644
--- a/repo/tests/phpunit/includes/api/EditEntityTest.php
+++ b/repo/tests/phpunit/includes/api/EditEntityTest.php
@@ -100,8 +100,6 @@
* Check if an entity can not be created whithout a token
*/
function testEditEntityNoToken() {
- $this->login();
-
if ( self::$usetoken ) {
try {
$this->doApiRequest(
diff --git a/repo/tests/phpunit/includes/api/EditPageTest.php
b/repo/tests/phpunit/includes/api/EditPageTest.php
index 4c6f5bd..67ab017 100644
--- a/repo/tests/phpunit/includes/api/EditPageTest.php
+++ b/repo/tests/phpunit/includes/api/EditPageTest.php
@@ -57,8 +57,6 @@
$this->assertTrue( $status->isOK(), $status->getMessage() ); //
sanity check
- $this->login();
-
$content->getItem()->setLabel( "de", "Test" );
$data = $content->getItem()->toArray();
$text = json_encode( $data );
@@ -83,8 +81,6 @@
$id = new \Wikibase\EntityId( \Wikibase\Item::ENTITY_TYPE,
1234567 );
$page =
\Wikibase\EntityContentFactory::singleton()->getWikiPageForId( $id );
-
- $this->login();
$text = "hallo welt";
--
To view, visit https://gerrit.wikimedia.org/r/77894
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I198a2052f3de5b6a286ae166ea692795e996bc76
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
