Addshore has submitted this change and it was merged.
Change subject: Fix API tests to not write into the main DB anymore
......................................................................
Fix API tests to not write into the main DB anymore
Change-Id: Ib5b5e9b943513a201eb42931a085674b8312a69e
---
M repo/tests/phpunit/includes/api/CreateClaimTest.php
M repo/tests/phpunit/includes/api/RemoveClaimsTest.php
2 files changed, 0 insertions(+), 9 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/tests/phpunit/includes/api/CreateClaimTest.php
b/repo/tests/phpunit/includes/api/CreateClaimTest.php
index 498bc80..d126206 100644
--- a/repo/tests/phpunit/includes/api/CreateClaimTest.php
+++ b/repo/tests/phpunit/includes/api/CreateClaimTest.php
@@ -103,8 +103,6 @@
}
public function invalidRequestProvider() {
- list( $entity, $property ) = self::getNewEntityAndProperty();
-
$argLists = array();
$params = array(
diff --git a/repo/tests/phpunit/includes/api/RemoveClaimsTest.php
b/repo/tests/phpunit/includes/api/RemoveClaimsTest.php
index ed2971a..2b0787e 100644
--- a/repo/tests/phpunit/includes/api/RemoveClaimsTest.php
+++ b/repo/tests/phpunit/includes/api/RemoveClaimsTest.php
@@ -160,16 +160,9 @@
}
public function invalidClaimProvider() {
- $entities = $this->entityProvider();
- $claimsOfEntity1 = $entities[0]->getClaims();
- $claimsOfEntity2 = $entities[1]->getClaims();
- $claim1OfEntity1 = $claimsOfEntity1[0];
- $claim1OfEntity2 = $claimsOfEntity2[0];
-
return array(
array( 'xyz' ), //wrong guid
array( 'x$y$z' ), //wrong guid
- array( array( $claim1OfEntity1->getGuid(),
$claim1OfEntity2->getGuid() ) ), //claims of different entities
);
}
--
To view, visit https://gerrit.wikimedia.org/r/77895
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5b5e9b943513a201eb42931a085674b8312a69e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
