Yuvipanda has submitted this change and it was merged.
Change subject: Remove bogus error handlers
......................................................................
Remove bogus error handlers
They just swallowed excepetions, mostly
Change-Id: I842904db1bd5b0b691569044c4401f443e457a0f
---
M src/github-to-gerrit.py
1 file changed, 3 insertions(+), 9 deletions(-)
Approvals:
Yuvipanda: Verified; Looks good to me, approved
diff --git a/src/github-to-gerrit.py b/src/github-to-gerrit.py
index a17d840..1ad6997 100644
--- a/src/github-to-gerrit.py
+++ b/src/github-to-gerrit.py
@@ -164,12 +164,6 @@
red = redis.StrictRedis(host=REDIS_HOST, db=REDIS_DB)
logger.info('Redis connection to %s succeded', REDIS_HOST)
- try:
- while True:
- data = json.loads(red.brpop(QUEUE_KEY)[1])
- do_review(data)
- except:
- gh.repos(OWNER, name).issues(pr_num).comments.post(body='Sorry, an
error occured :( @yuvipanda will now be notified that this sync did not end
well')
- logging.exception("Error!")
- finally:
- sys.exit(-1)
+ while True:
+ data = json.loads(red.brpop(QUEUE_KEY)[1])
+ do_review(data)
--
To view, visit https://gerrit.wikimedia.org/r/77713
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I842904db1bd5b0b691569044c4401f443e457a0f
Gerrit-PatchSet: 5
Gerrit-Project: labs/tools/SuchABot
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
