jenkins-bot has submitted this change and it was merged.
Change subject: More informative warning of validation errors
......................................................................
More informative warning of validation errors
For example, "Unrecognized property: isNew" becomes "Validation error
against schema GettingStartedOnRedirect: Unrecognized property: isNew"
Maybe also warn() should prefix everything with "EventLogging", since
the line number of the warning is in jQuery proxy().
Change-Id: I9bdc4a0d508433a5ad0b5c0936e2493371bea129
---
M modules/ext.eventLogging.core.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.eventLogging.core.js b/modules/ext.eventLogging.core.js
index 0f4313f..e9be178 100644
--- a/modules/ext.eventLogging.core.js
+++ b/modules/ext.eventLogging.core.js
@@ -131,7 +131,7 @@
if ( !( e instanceof ValidationError ) ) {
throw e;
}
- self.warn( e.message );
+ self.warn( 'Validation error against schema ' +
schemaName + ': ' + e.message );
return false;
}
},
--
To view, visit https://gerrit.wikimedia.org/r/77974
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9bdc4a0d508433a5ad0b5c0936e2493371bea129
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
