jenkins-bot has submitted this change and it was merged.
Change subject: Get rid of getPrefixedId in EntityIdPropertyUpdater
......................................................................
Get rid of getPrefixedId in EntityIdPropertyUpdater
Change-Id: I4550bdb61a2a3285cde30a7cda03743d659789ff
---
M client/includes/EntityIdPropertyUpdater.php
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/client/includes/EntityIdPropertyUpdater.php
b/client/includes/EntityIdPropertyUpdater.php
index b7ae74c..efd638c 100644
--- a/client/includes/EntityIdPropertyUpdater.php
+++ b/client/includes/EntityIdPropertyUpdater.php
@@ -4,6 +4,7 @@
use ParserOutput;
use Title;
+use Wikibase\Client\WikibaseClient;
use Wikibase\DataModel\SimpleSiteLink;
/**
@@ -69,8 +70,8 @@
$itemId = $this->siteLinkLookup->getEntityIdForSiteLink(
$siteLink );
if ( $itemId instanceof EntityId ) {
- // @todo get prefixed id in nicer way, or maybe we want
it to be numeric id
- $out->setProperty( 'wikibase_item',
$itemId->getPrefixedId() );
+ $idFormatter =
WikibaseClient::getDefaultInstance()->getEntityIdFormatter();
+ $out->setProperty( 'wikibase_item',
$idFormatter->format( $itemId ) );
} else {
// unset property, if it was set
$this->unsetProperty( $out, 'wikibase_item' );
--
To view, visit https://gerrit.wikimedia.org/r/77335
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4550bdb61a2a3285cde30a7cda03743d659789ff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
