Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/78052
Change subject: Use params->kwargs mapping to determine database name
......................................................................
Use params->kwargs mapping to determine database name
"map['database']" is a remnant of code that mostly removed in
change I9c12ee6f2. Before that change, 'map' was a mapping of arguments
provided by pymongo.uri_parser. After it, map was not getting assigned, and
thus defaulted to the built-in map method.
The correct way to receive arguments specified via the URI is to rely on
deparam & call to map the URI params to kwargs.
Change-Id: I7882b2a9877aac50069ec2349a236b39abe9f42a
---
M server/eventlogging/handlers.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging
refs/changes/52/78052/1
diff --git a/server/eventlogging/handlers.py b/server/eventlogging/handlers.py
index d2ad3cf..e34587a 100644
--- a/server/eventlogging/handlers.py
+++ b/server/eventlogging/handlers.py
@@ -65,9 +65,9 @@
#
@writes('mongodb')
-def mongodb_writer(uri):
+def mongodb_writer(uri, database='events'):
client = pymongo.MongoClient(uri)
- db = client[map['database'] or 'events']
+ db = client[database]
datetime_from_timestamp = datetime.datetime.fromtimestamp
while 1:
--
To view, visit https://gerrit.wikimedia.org/r/78052
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7882b2a9877aac50069ec2349a236b39abe9f42a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
