jenkins-bot has submitted this change and it was merged.
Change subject: Fix jsduck warnings
......................................................................
Fix jsduck warnings
Change-Id: I7cb183589e897d1fb3923a678e067a21a2ebdf4e
---
M js/lib/ext.util.TokenCollector.js
M js/lib/mediawiki.Util.js
M js/tests/parserTests.js
3 files changed, 12 insertions(+), 12 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
Cscott: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/js/lib/ext.util.TokenCollector.js
b/js/lib/ext.util.TokenCollector.js
index b53972e..3ab7701 100644
--- a/js/lib/ext.util.TokenCollector.js
+++ b/js/lib/ext.util.TokenCollector.js
@@ -1,3 +1,12 @@
+"use strict";
+
+// define some constructor shortcuts
+var defines = require('./mediawiki.parser.defines.js');
+var EOFTk = defines.EOFTk,
+ TagTk = defines.TagTk,
+ SelfclosingTagTk = defines.SelfclosingTagTk,
+ EndTagTk = defines.EndTagTk;
+
/**
* @class
*
@@ -21,16 +30,6 @@
* @param {string} type Token type to register for ('tag', 'text' etc)
* @param {string} name (optional, only for token type 'tag'): tag name.
*/
-
-"use strict";
-
-// define some constructor shortcuts
-var defines = require('./mediawiki.parser.defines.js');
-var EOFTk = defines.EOFTk,
- TagTk = defines.TagTk,
- SelfclosingTagTk = defines.SelfclosingTagTk,
- EndTagTk = defines.EndTagTk;
-
function TokenCollector ( manager, transformation, toEnd, rank, type, name ) {
this.transformation = transformation;
this.manager = manager;
diff --git a/js/lib/mediawiki.Util.js b/js/lib/mediawiki.Util.js
index 6adc9cb..ea8b4f1 100644
--- a/js/lib/mediawiki.Util.js
+++ b/js/lib/mediawiki.Util.js
@@ -944,10 +944,11 @@
};
/**
+ * @method
+ *
* Utility function for stripping useless paragraphs from the beginning of a
list item,
* because they get appended by VisualEditor sometimes.
*/
-// FIXME: Dead function? SelectiveSerializer doesn't seem to use this
Util.stripFirstParagraph = function ( node ) {
var thisnode, hasAttrs, dataParsoid, attrs, exemptAttrs = 0;
for ( var i = 0; i < node.childNodes.length; i++ ) {
diff --git a/js/tests/parserTests.js b/js/tests/parserTests.js
index 9c84362..fedee0d 100755
--- a/js/tests/parserTests.js
+++ b/js/tests/parserTests.js
@@ -708,7 +708,6 @@
cb( null, content, changeTree );
};
-ParserTests.prototype.convertWt2Html = function( mode, wikitext, processHtmlCB
) {
/**
* @method
* @param {string} mode
@@ -717,6 +716,7 @@
* @param {Error/null} processHtmlCB.err
* @param {Node/null} processHtmlCB.doc
*/
+ParserTests.prototype.convertWt2Html = function( mode, wikitext, processHtmlCB
) {
try {
this.parserPipeline.once( 'document', function ( doc ) {
// processHtmlCB can be asynchronous, so deep-clone
--
To view, visit https://gerrit.wikimedia.org/r/54881
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7cb183589e897d1fb3923a678e067a21a2ebdf4e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: MarkTraceur <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
