Siebrand has uploaded a new change for review.
https://gerrit.wikimedia.org/r/78182
Change subject: Add some FIXMEs based on static code analysis
......................................................................
Add some FIXMEs based on static code analysis
Change-Id: If7f276ff66926d2e375da68401fa7d83c00fd12b
---
M MassMessage.body.php
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage
refs/changes/82/78182/1
diff --git a/MassMessage.body.php b/MassMessage.body.php
index e6f0c36..8e8c05a 100644
--- a/MassMessage.body.php
+++ b/MassMessage.body.php
@@ -95,16 +95,21 @@
* @return string
*/
public static function getDBName( $host ) {
+ // @todo FIXME $this is not available in static context.
if ( isset( $this->dbnames[$host] ) ) {
+ // @todo FIXME $this is not available in static context.
return $this->dbnames[$host];
}
if ( !class_exists( 'SiteMatrix' ) ) {
return null;
}
$matrix = new SiteMatrix();
+ // @todo FIXME Member has protected access.
+ // See extension TranslationNotifications,
SpecialTranslatorSignup::getOtherWikis()
foreach ( $matrix->hosts as $dbname => $url ) {
$parse = wfParseUrl( $url );
if ( $parse['host'] == $host ) {
+ // @todo FIXME $this is not available in static
context.
$this->dbnames[$host] = $dbname; // Store it
for later
return $dbname;
}
--
To view, visit https://gerrit.wikimedia.org/r/78182
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If7f276ff66926d2e375da68401fa7d83c00fd12b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MassMessage
Gerrit-Branch: master
Gerrit-Owner: Siebrand <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
