Rfaulk has submitted this change and it was merged.
Change subject: fix. request object construction in process_metrics.
......................................................................
fix. request object construction in process_metrics.
Change-Id: I259b377a16d8ff94f97d31ca108adb7b46082a61
---
M user_metrics/api/engine/request_manager.py
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Rfaulk: Verified; Looks good to me, approved
diff --git a/user_metrics/api/engine/request_manager.py
b/user_metrics/api/engine/request_manager.py
index a325a0b..9117ed9 100644
--- a/user_metrics/api/engine/request_manager.py
+++ b/user_metrics/api/engine/request_manager.py
@@ -87,7 +87,8 @@
RESPONSE_BROKER_TARGET, PROCESS_BROKER_TARGET
from user_metrics.api.engine import pack_response_for_broker
from user_metrics.api.engine.data import get_users
-from user_metrics.api.engine.request_meta import build_request_obj
+from user_metrics.api.engine.request_meta import build_request_obj, \
+ parse_raw_request
from user_metrics.metrics.users import MediaWikiUser
from user_metrics.metrics.user_metric import UserMetricError
@@ -216,7 +217,7 @@
logging.debug('{0} - FINISHING.'.format(log_name))
-def process_metrics(p, request):
+def process_metrics(p, request_url):
"""
Worker process for requests, forked from the job controller. This
method handles:
@@ -230,13 +231,13 @@
logging.info(log_name + ' - START JOB'
'\n\t{0} - PID = {1})'.
- format(request, getpid()))
+ format(request_url, getpid()))
err_msg = __name__ + ' :: Request failed.'
users = list()
try:
- request_obj = build_request_obj(request)
+ request_obj = build_request_obj(request_url)
except MetricsAPIError as e:
# TODO - flag job as failed
return
--
To view, visit https://gerrit.wikimedia.org/r/78208
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I259b377a16d8ff94f97d31ca108adb7b46082a61
Gerrit-PatchSet: 1
Gerrit-Project: analytics/user-metrics
Gerrit-Branch: master
Gerrit-Owner: Rfaulk <[email protected]>
Gerrit-Reviewer: Rfaulk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
