Rfaulk has submitted this change and it was merged.
Change subject: fix. change parse_raw_request to define args as dict (iterable).
......................................................................
fix. change parse_raw_request to define args as dict (iterable).
Change-Id: I53bdbe40cfd077949661c8780b2b4dd2813e6b7d
---
M user_metrics/api/engine/request_meta.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Rfaulk: Verified; Looks good to me, approved
diff --git a/user_metrics/api/engine/request_meta.py
b/user_metrics/api/engine/request_meta.py
index 065c3ba..8b28761 100644
--- a/user_metrics/api/engine/request_meta.py
+++ b/user_metrics/api/engine/request_meta.py
@@ -74,13 +74,13 @@
args = namedtuple('UM_REQUEST_ARGS', '')
if len(bits) > 1:
args_expr = [i.split('=') for i in bits[1].split('&')]
- args = recordtype('UM_REQUEST_ARGS', ' '.join([i[0] for i in
args_expr]))
+ args = dict()
for arg in args_expr:
if len(arg) == 1:
# The arg is simply present
- setattr(args, arg[0], True)
+ args[arg[0]] = True
else:
- setattr(args, arg[0], arg[1])
+ args[arg[0]] = arg[1]
return namedtuple('UM_REQUEST', 'cohort metric args')(cohort, metric, args)
--
To view, visit https://gerrit.wikimedia.org/r/78210
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53bdbe40cfd077949661c8780b2b4dd2813e6b7d
Gerrit-PatchSet: 1
Gerrit-Project: analytics/user-metrics
Gerrit-Branch: master
Gerrit-Owner: Rfaulk <[email protected]>
Gerrit-Reviewer: Rfaulk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
