jenkins-bot has submitted this change and it was merged.
Change subject: Accessibility: make columnheader the primary role of the element
......................................................................
Accessibility: make columnheader the primary role of the element
The role attribute overrides implicit roles. Since here the
columnheader role of the th is more important than the secondary role
of being a button, we should force it explicitly in that order.
Follow up of: I2b937eba605b7e6a98612a02c75eb9e7f3477527
Change-Id: I07211263876a58c62e5a349eab6f78e43d412680
---
M resources/jquery/jquery.tablesorter.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Matmarex: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/jquery/jquery.tablesorter.js
b/resources/jquery/jquery.tablesorter.js
index 115a49a..cac056e 100644
--- a/resources/jquery/jquery.tablesorter.js
+++ b/resources/jquery/jquery.tablesorter.js
@@ -347,7 +347,7 @@
.addClass( table.config.cssHeader )
.prop( 'tabIndex', 0 )
.attr( {
- role: 'button',
+ role: 'columnheader button',
title: msg[1]
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/78066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I07211263876a58c62e5a349eab6f78e43d412680
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: TheDJ <[email protected]>
Gerrit-Reviewer: Matmarex <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
