Rfaulk has submitted this change and it was merged.
Change subject: add. exception and logging to cases where removing items from
the process queue fails.
......................................................................
add. exception and logging to cases where removing items from the process queue
fails.
Change-Id: I7578d1e37bc6716531bb56144ce04a614c4d34fa
---
M user_metrics/api/engine/request_manager.py
1 file changed, 8 insertions(+), 1 deletion(-)
Approvals:
Rfaulk: Verified; Looks good to me, approved
diff --git a/user_metrics/api/engine/request_manager.py
b/user_metrics/api/engine/request_manager.py
index 9117ed9..c26a6bc 100644
--- a/user_metrics/api/engine/request_manager.py
+++ b/user_metrics/api/engine/request_manager.py
@@ -184,7 +184,14 @@
# Remove from process target
url_hash = sha1(job_item.request.encode('utf-8')).hexdigest()
- umapi_broker_context.remove(PROCESS_BROKER_TARGET, url_hash)
+ try:
+ umapi_broker_context.remove(PROCESS_BROKER_TARGET,
url_hash)
+ except Exception as e:
+ logging.error(__name__ + ' :: Could not process '
+ '{0} from {1} -- {2}'.
+ format(job_item.request,
+ PROCESS_BROKER_TARGET,
+ e.message))
# Add to response target
umapi_broker_context.add(RESPONSE_BROKER_TARGET, url_hash,
--
To view, visit https://gerrit.wikimedia.org/r/78473
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7578d1e37bc6716531bb56144ce04a614c4d34fa
Gerrit-PatchSet: 1
Gerrit-Project: analytics/user-metrics
Gerrit-Branch: master
Gerrit-Owner: Rfaulk <[email protected]>
Gerrit-Reviewer: Rfaulk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
