Yuvipanda has submitted this change and it was merged.
Change subject: Do not keep redis connections open all the time either
......................................................................
Do not keep redis connections open all the time either
Registrar is gonna get called a very small number of times, so
no reason to keep a connection open
Change-Id: I64e2398027f052978b0df7c50ef8acff3a0ba593
---
M src/registrar.py
1 file changed, 7 insertions(+), 5 deletions(-)
Approvals:
Yuvipanda: Verified; Looks good to me, approved
diff --git a/src/registrar.py b/src/registrar.py
index bbfa3fa..b9f7bc3 100755
--- a/src/registrar.py
+++ b/src/registrar.py
@@ -31,13 +31,15 @@
logging.basicConfig(format='%(asctime)s %(message)s',
filename=os.path.expanduser('~/logs/stream-subscriptions'), level=logging.INFO)
-logging.info('Attempting to Redis connection to %s', REDIS_HOST)
-red = redis.StrictRedis(host=REDIS_HOST, db=REDIS_DB)
-logging.info('Redis connection to %s succeded', REDIS_HOST)
class Service(object):
def __init__(self, service_name):
self.service = SERVICES[service_name]
+
+ logging.info('Attempting to Redis connection to %s', REDIS_HOST)
+ self.redis = redis.StrictRedis(host=REDIS_HOST, db=REDIS_DB)
+ logging.info('Redis connection to %s succeded', REDIS_HOST)
+
logging.info('Attempting to connect to MySql on %s', MYSQL_HOST)
self.db = storage.DB(MYSQL_HOST, MYSQL_DB)
logging.info('MySql connection to %s suceceded', MYSQL_HOST)
@@ -49,14 +51,14 @@
def add_subscription(self, msg):
key = generate_random_string(32)
clients_key = self._make_key(self.service['clients_key'])
- red.pipeline().sadd(clients_key, key).save().execute()
self.db.insert(key, msg['service'], msg['description'],
msg['createdby'])
+ self.redis.pipeline().sadd(clients_key, key).save().execute()
logging.info('Added key %s' % key)
return "Created key: %s and started subscription" % key
def delete_subscription(msg):
clients_key = self._make_key(self.service['clients_key'])
- red.pipeline().delete(msg['key']).srem(clients_key,
msg['key']).save().execute()
+ self.redis.pipeline().delete(msg['key']).srem(clients_key,
msg['key']).save().execute()
logging.info('Removed key %s' % msg['key'])
return "Removed key"
--
To view, visit https://gerrit.wikimedia.org/r/78494
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64e2398027f052978b0df7c50ef8acff3a0ba593
Gerrit-PatchSet: 1
Gerrit-Project: labs/tools/gerrit-to-redis
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
Gerrit-Reviewer: Yuvipanda <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
