Reedy has uploaded a new change for review.
https://gerrit.wikimedia.org/r/78537
Change subject: Minor doc additions
......................................................................
Minor doc additions
Change-Id: I732c56d266c3ac55150290c6421b939387edbc88
---
M backend/CodeRevision.php
M maintenance/svnImport.php
M ui/CodeRevisionCommitter.php
M ui/CodeRevisionView.php
M ui/CodeView.php
5 files changed, 27 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeReview
refs/changes/37/78537/1
diff --git a/backend/CodeRevision.php b/backend/CodeRevision.php
index 658c2bb..ceb4b7e 100644
--- a/backend/CodeRevision.php
+++ b/backend/CodeRevision.php
@@ -704,6 +704,9 @@
$users[0] = $watcher; // We don't have any anons, so
using 0 is safe
}
+ /**
+ * @var $user User
+ */
foreach ( $users as $id => $user ) {
// No sense in notifying this commenter
if ( $wgUser->getId() == $user->getId() ) {
diff --git a/maintenance/svnImport.php b/maintenance/svnImport.php
index 5496e08..228e05b 100644
--- a/maintenance/svnImport.php
+++ b/maintenance/svnImport.php
@@ -37,6 +37,9 @@
if ( $repo == "all" ) {
$repoList = CodeRepository::getRepoList();
+ /**
+ * @var $repoInfo CodeRepository
+ */
foreach ( $repoList as $repoInfo ) {
$this->importRepo( $repoInfo->getName(), null,
$cacheSize );
}
diff --git a/ui/CodeRevisionCommitter.php b/ui/CodeRevisionCommitter.php
index 6eabbae..91ac4bb 100644
--- a/ui/CodeRevisionCommitter.php
+++ b/ui/CodeRevisionCommitter.php
@@ -65,7 +65,6 @@
* @param Array $removeReferences Array of revision IDs to remove
references from
* @param string $commentText Comment to add to the revision
* @param null|int $parent What the parent comment is (if a subcomment)
- * @param int $review (unused)
* @param $addReferenced
* @param $removeReferenced
* @return int Comment ID if added, else 0
diff --git a/ui/CodeRevisionView.php b/ui/CodeRevisionView.php
index c979339..bd932e2 100644
--- a/ui/CodeRevisionView.php
+++ b/ui/CodeRevisionView.php
@@ -243,7 +243,7 @@
if ( $prev ) {
$prevTarget = SpecialPage::getTitleFor( 'Code',
"$repo/$prev" );
$links[] = '< ' . Linker::link( $prevTarget,
$this->mRev->getIdString( $prev ),
- array(), array( 'path' => $this->mPath )
).$wgLang->getDirMark();
+ array(), array( 'path' => $this->mPath ) ) .
$wgLang->getDirMark();
}
$revText = "<b>" . $this->mRev->getIdString( $rev ) . "</b>";
@@ -251,7 +251,7 @@
if ( $viewvc ) {
$url = htmlspecialchars(
"$viewvc/?view=rev&revision=$rev" );
$viewvcTxt = wfMessage( 'code-rev-rev-viewvc'
)->escaped();
- $revText .= " (<a href=\"$url\" title=\"revision
$rev\">$viewvcTxt</a>)".$wgLang->getDirMark();
+ $revText .= " (<a href=\"$url\" title=\"revision
$rev\">$viewvcTxt</a>)" . $wgLang->getDirMark();
}
$links[] = $revText;
@@ -850,7 +850,7 @@
*/
protected function commentStyle( $comment ) {
global $wgLang;
- $align = $wgLang->AlignStart();
+ $align = $wgLang->alignStart();
$depth = $comment->threadDepth();
$margin = ( $depth - 1 ) * 48;
return "margin-$align: ${margin}px";
@@ -942,6 +942,9 @@
protected function getUserSignoffs( $signOffs ) {
$ret = array();
global $wgUser;
+ /**
+ * @var $s CodeSignoff
+ */
foreach( $signOffs as $s ) {
if ( $s->userText == $wgUser->getName() &&
!$s->isStruck() ) {
$ret[$s->flag] = true;
diff --git a/ui/CodeView.php b/ui/CodeView.php
index 9adde5d..1e3324e 100644
--- a/ui/CodeView.php
+++ b/ui/CodeView.php
@@ -19,6 +19,21 @@
*/
var $codeCommentLinkerWiki;
+ /**
+ * @var string
+ */
+ var $mPath;
+
+ /**
+ * @var string
+ */
+ var $mAuthor;
+
+ /**
+ * @var string
+ */
+ var $mStatus;
+
function __construct( $repo ) {
$this->mRepo = ( $repo instanceof CodeRepository )
? $repo
--
To view, visit https://gerrit.wikimedia.org/r/78537
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I732c56d266c3ac55150290c6421b939387edbc88
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeReview
Gerrit-Branch: master
Gerrit-Owner: Reedy <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
