Nemo bis has uploaded a new change for review.
https://gerrit.wikimedia.org/r/78544
Change subject: articlefeedback-pitch-thanks should be in singular form if the
user submits only one rating
......................................................................
articlefeedback-pitch-thanks should be in singular form if the user submits
only one rating
Bug: 29323
Change-Id: Icb2f6c7eaf15a0ae2a10a4164874454a3e9394f9
---
M ArticleFeedback.hooks.php
M ArticleFeedback.i18n.php
M modules/jquery.articleFeedback/jquery.articleFeedback.js
3 files changed, 4 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedback
refs/changes/44/78544/1
diff --git a/ArticleFeedback.hooks.php b/ArticleFeedback.hooks.php
index 43e3351..4ff6cf6 100644
--- a/ArticleFeedback.hooks.php
+++ b/ArticleFeedback.hooks.php
@@ -32,6 +32,7 @@
'articlefeedback-privacyurl'
),
'dependencies' => array(
+ 'mediawiki.jqueryMsg',
'jquery.ui.dialog',
'jquery.ui.button',
'jquery.articleFeedback',
diff --git a/ArticleFeedback.i18n.php b/ArticleFeedback.i18n.php
index 18bf9ca..b9b5f7b 100644
--- a/ArticleFeedback.i18n.php
+++ b/ArticleFeedback.i18n.php
@@ -67,7 +67,7 @@
'articlefeedback-field-wellwritten-tooltip-5' => 'Exceptional clarity',
'articlefeedback-pitch-reject' => 'Maybe later',
'articlefeedback-pitch-or' => 'or',
- 'articlefeedback-pitch-thanks' => 'Thanks! Your ratings have been
saved.',
+ 'articlefeedback-pitch-thanks' => 'Thanks! Your {{PLURAL:$1|rating
has|ratings have}} been saved.',
'articlefeedback-pitch-join-message' => 'Did you want to create an
account?',
'articlefeedback-pitch-join-body' => 'An account will help you track
your edits, get involved in discussions, and be a part of the community.',
'articlefeedback-pitch-join-accept' => 'Create an account',
@@ -161,6 +161,7 @@
'articlefeedback-pitch-join-accept' => '{{Identical|Create an
account}}',
'articlefeedback-pitch-join-login' => '{{Identical|Log in}}',
'articlefeedback-pitch-edit-body' => '{{notranslate}}',
+ 'articlefeedback-pitch-thanks' => '$1 - number of ratings submitted',
'articlefeedback-privacyurl' => 'This URL can be changed to point to a
translated version of the page if it exists.',
'articleFeedback-table-caption-dailyhighs' => "Used as caption.
Parameters:
* $1 - today's date",
diff --git a/modules/jquery.articleFeedback/jquery.articleFeedback.js
b/modules/jquery.articleFeedback/jquery.articleFeedback.js
index 19eea0f..5914283 100644
--- a/modules/jquery.articleFeedback/jquery.articleFeedback.js
+++ b/modules/jquery.articleFeedback/jquery.articleFeedback.js
@@ -564,7 +564,7 @@
var $pitch = $(
$.articleFeedback.tpl.pitch )
.attr( 'rel',
key )
.find(
'.articleFeedback-title' )
- .text(
mw.msg( context.options.pitches[key].title ) )
+ .text(
mw.msg( context.options.pitches[key].title, rating.countall ) )
.end()
.find(
'.articleFeedback-message' )
.text(
mw.msg( context.options.pitches[key].message ) )
--
To view, visit https://gerrit.wikimedia.org/r/78544
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb2f6c7eaf15a0ae2a10a4164874454a3e9394f9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedback
Gerrit-Branch: master
Gerrit-Owner: Nemo bis <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
