Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/78807
Change subject: Get rid of deprecated method in ItemByTitleHelper
......................................................................
Get rid of deprecated method in ItemByTitleHelper
Change-Id: I2e98353c8929baa153158fc6a76cb01ebcd5b997
---
M repo/includes/api/ItemByTitleHelper.php
M repo/tests/phpunit/includes/api/ItemByTitleHelperTest.php
2 files changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/07/78807/1
diff --git a/repo/includes/api/ItemByTitleHelper.php
b/repo/includes/api/ItemByTitleHelper.php
index 2aceb2a..f136c78 100644
--- a/repo/includes/api/ItemByTitleHelper.php
+++ b/repo/includes/api/ItemByTitleHelper.php
@@ -3,6 +3,7 @@
namespace Wikibase\Api;
use Wikibase\EntityId;
use Wikibase\Item;
+use Wikibase\Repo\WikibaseRepo;
/**
* Helper class for api modules to resolve page+title pairs into items.
@@ -107,8 +108,10 @@
array( 'site' => $siteId, 'title' =>
$title, 'missing' => "" )
);
} else {
+ $entityIdFormatter =
WikibaseRepo::getDefaultInstance()->getEntityIdFormatter();
+
$id = new EntityId( Item::ENTITY_TYPE, $id );
- $ids[] = $id->getPrefixedId();
+ $ids[] = $entityIdFormatter->format( $id );
}
}
diff --git a/repo/tests/phpunit/includes/api/ItemByTitleHelperTest.php
b/repo/tests/phpunit/includes/api/ItemByTitleHelperTest.php
index 1b2f6d8..74649bb 100644
--- a/repo/tests/phpunit/includes/api/ItemByTitleHelperTest.php
+++ b/repo/tests/phpunit/includes/api/ItemByTitleHelperTest.php
@@ -4,6 +4,7 @@
use Wikibase\Api\ItemByTitleHelper;
use Wikibase\EntityId;
use Wikibase\Item;
+use Wikibase\Repo\WikibaseRepo;
use Wikibase\Settings;
use Wikibase\StringNormalizer;
@@ -101,8 +102,10 @@
}
public function testGetEntityIdsSuccess() {
+ $entityIdFormatter =
WikibaseRepo::getDefaultInstance()->getEntityIdFormatter();
+
$expectedEntityId = new EntityId( Item::ENTITY_TYPE, 123 );
- $expectedEntityId = $expectedEntityId->getPrefixedId();
+ $expectedEntityId = $entityIdFormatter->format(
$expectedEntityId );
$itemByTitleHelper = new ItemByTitleHelper(
$this->getApiBaseMock( 0 ),
--
To view, visit https://gerrit.wikimedia.org/r/78807
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e98353c8929baa153158fc6a76cb01ebcd5b997
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
