Mwjames has uploaded a new change for review. https://gerrit.wikimedia.org/r/78931
Change subject: \SMW\Test\FeedResultPrinterTest ...................................................................... \SMW\Test\FeedResultPrinterTest Following the discussion on [1] [1] http://www.semantic-mediawiki.org/wiki/Help_talk:Feed_format#RSS.2FAtom_output_and_HTML_tag_support_503 Change-Id: Icb19169a913a0044c0f6672db373751e09a351fd --- M tests/phpunit/includes/queryprinters/FeedResultPrinterTest.php 1 file changed, 54 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/31/78931/1 diff --git a/tests/phpunit/includes/queryprinters/FeedResultPrinterTest.php b/tests/phpunit/includes/queryprinters/FeedResultPrinterTest.php index 93beb3f..2eaecac 100644 --- a/tests/phpunit/includes/queryprinters/FeedResultPrinterTest.php +++ b/tests/phpunit/includes/queryprinters/FeedResultPrinterTest.php @@ -39,7 +39,7 @@ * * @return FeedResultPrinter */ - private function getInstance( $parameters = array() ) { + private function newInstance( $parameters = array() ) { return $this->setParameters( new FeedResultPrinter( 'feed' ), $parameters ); } @@ -49,7 +49,59 @@ * @since 1.9 */ public function testConstructor() { - $this->assertInstanceOf( $this->getClass(), $this->getInstance() ); + $this->assertInstanceOf( $this->getClass(), $this->newInstance() ); } + /** + * @test FeedResultPrinter::feedItemDescription + * @dataProvider textDataProvider + * + * @since 1.9 + */ + public function testFeedItemDescription( $setup, $expected, $message ) { + + $instance = $this->newInstance(); + + $reflector = $this->newReflector(); + $method = $reflector->getMethod( 'feedItemDescription' ); + $method->setAccessible( true ); + + $this->assertEquals( + $expected['text'], + $method->invoke( $instance, $setup['items'], $setup['pageContent'] ), + 'Failed asserting ' . $message['info'] + ); + + } + + + /** + * @return array + */ + public function textDataProvider() { + + $provider = array(); + + // #0 + // http://www.utexas.edu/learn/html/spchar.html + $provider[] = array( + array( + 'items' => array(), + 'pageContent' => 'Semantic MediaWiki Conference, have been announced: it will be held at' . + '[http://www.aohostels.com/en/tagungen/tagungen-berlin/ A&O Berlin Hauptbahnhof]' . + '&¢©«»—¡¿,åÃãÆç' + ), + array( + 'text' => 'Semantic MediaWiki Conference, have been announced: it will be held at' . + '[http://www.aohostels.com/en/tagungen/tagungen-berlin/ A&O Berlin Hauptbahnhof]' . + '&¢©«»—¡¿,åÃãÆç' + ), + array( 'info' => 'text enconding including html special characters' ) + ); + + return $provider; + + } + + } -- To view, visit https://gerrit.wikimedia.org/r/78931 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icb19169a913a0044c0f6672db373751e09a351fd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Mwjames <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
