Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/78954
Change subject: Minor style fixes
......................................................................
Minor style fixes
Change-Id: I464a19cc1f56c98c210df39cf293a10f5658eab0
---
M repo/tests/phpunit/includes/api/LangAttributeTestCase.php
1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/54/78954/1
diff --git a/repo/tests/phpunit/includes/api/LangAttributeTestCase.php
b/repo/tests/phpunit/includes/api/LangAttributeTestCase.php
index 1f0e849..9f79f6c 100644
--- a/repo/tests/phpunit/includes/api/LangAttributeTestCase.php
+++ b/repo/tests/phpunit/includes/api/LangAttributeTestCase.php
@@ -94,10 +94,10 @@
'e' => array( 'value' => array( 'bat-smg' =>
'V?sata' ) ) ),
array( //7
'p' => array( 'language' => 'bat-smg', 'value'
=> '' ),
- 'e' => array( ) ),
+ 'e' => array() ),
);
}
-
+
public function doTestSetLangAttribute( $attribute ,$params, $expected
){
// -- set any defaults ------------------------------------
$params['action'] = self::$testAction;
@@ -118,18 +118,18 @@
// -- check the result only has our changed data (if any)
------------
$this->assertEquals( 1, count( $result['entity'][$attribute] ),
"Entity return contained more than a single language" );
- $this->assertArrayHasKey( $params['language'],
$result['entity'][$attribute], "Entity doesn't return expected language");
+ $this->assertArrayHasKey( $params['language'],
$result['entity'][$attribute], "Entity doesn't return expected language" );
$this->assertEquals( $params['language'],
$result['entity'][$attribute][ $params['language'] ]['language'], "Returned
incorrect language" );
if( array_key_exists( $params['language'], $expected['value'] )
){
$this->assertEquals( $expected['value'][
$params['language'] ],
$result['entity'][$attribute][$params['language']]['value'] , "Returned
incorrect label" );
} else if( empty( $value ) ){
- $this->assertArrayHasKey( 'removed',
$result['entity'][$attribute][ $params['language'] ], "Entity doesn't return
expected 'removed' marker");
+ $this->assertArrayHasKey( 'removed',
$result['entity'][$attribute][ $params['language'] ], "Entity doesn't return
expected 'removed' marker" );
}
// -- check any warnings
----------------------------------------------
if( array_key_exists( 'warning', $expected ) ){
$this->assertArrayHasKey( 'warnings', $result, "Missing
'warnings' section in response." );
- $this->assertEquals( $expected['warning'],
$result['warnings']['messages']['0']['name']);
+ $this->assertEquals( $expected['warning'],
$result['warnings']['messages']['0']['name'] );
$this->assertArrayHasKey( 'html',
$result['warnings']['messages'] );
}
@@ -149,7 +149,7 @@
// -- check the edit summary
--------------------------------------------
if( !array_key_exists( 'warning', $expected ) ||
$expected['warning'] != 'edit-no-change' ){
$this->assertRevisionSummary( array( self::$testAction,
$params['language'] ), $result['entity']['lastrevid'] );
- if( array_key_exists( 'summary', $params) ){
+ if( array_key_exists( 'summary', $params ) ){
$this->assertRevisionSummary(
"/{$params['summary']}/" , $result['entity']['lastrevid'] );
}
}
@@ -205,7 +205,7 @@
} else {
$this->doApiRequestWithToken( $params );
}
- $this->fail( "Failed to throw exception,
{$expected['exception']['type']} " );
+ $this->fail( "Failed to throw exception,
{$expected['exception']['type']}" );
} catch( \Exception $exception ){
--
To view, visit https://gerrit.wikimedia.org/r/78954
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I464a19cc1f56c98c210df39cf293a10f5658eab0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
