jenkins-bot has submitted this change and it was merged.

Change subject: Fixed dynamic call to static method
......................................................................


Fixed dynamic call to static method

Change-Id: I3596b90c0e9ada03c8170b21c988a58a1a56aa8f
---
M backend/MWOAuthDataStore.php
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Demon: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/backend/MWOAuthDataStore.php b/backend/MWOAuthDataStore.php
index e513805..6621987 100644
--- a/backend/MWOAuthDataStore.php
+++ b/backend/MWOAuthDataStore.php
@@ -96,8 +96,8 @@
         */
        public static function newToken() {
                return new MWOAuthToken(
-                       MWCryptRand::generateHex( 32, false), // the key 
doesn't need to be unpredictable
-                       MWCryptRand::generateHex( 32, true)
+                       MWCryptRand::generateHex( 32, false ), // the key 
doesn't need to be unpredictable
+                       MWCryptRand::generateHex( 32, true )
                );
        }
 
@@ -107,7 +107,7 @@
         * @param MWOAuthConsumer|OAuthConsumer $consumer
         */
        public function new_request_token( $consumer, $callback = null ) {
-               $token = $this->newToken();
+               $token = MWOAuthDataStore::newToken();
                $cacheKey = MWOAuthUtils::getCacheKey( 'token', $consumer->key, 
'request', $token->key );
                $this->cache->add( $cacheKey, $token, 600 ); //10 minutes. 
Kindof arbitray.
                wfDebugLog( 'OAuth', __METHOD__ .

-- 
To view, visit https://gerrit.wikimedia.org/r/75274
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3596b90c0e9ada03c8170b21c988a58a1a56aa8f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Demon <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to