Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/79053
Change subject: Add aria properties to TOC toggle link
......................................................................
Add aria properties to TOC toggle link
Change-Id: Ic493fe3ab38b0bca477a40db4eb420be875b2efa
---
M resources/mediawiki/mediawiki.util.js
1 file changed, 28 insertions(+), 21 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/53/79053/1
diff --git a/resources/mediawiki/mediawiki.util.js
b/resources/mediawiki/mediawiki.util.js
index 071a52b..25b4d30 100644
--- a/resources/mediawiki/mediawiki.util.js
+++ b/resources/mediawiki/mediawiki.util.js
@@ -112,6 +112,10 @@
hideTocCookie = $.cookie( 'mw_hidetoc' );
$tocToggleLink = $( '<a href="#"
class="internal" id="togglelink"></a>' )
.text( mw.msg( 'hidetoc' ) )
+ .prop( {
+ 'aria-controls': 'toc',
+ 'aria-expanded': true
+ } )
.click( function ( e ) {
e.preventDefault();
util.toggleToc( $(this)
);
@@ -221,29 +225,32 @@
// This function shouldn't be called if there's no TOC,
// but just in case...
- if ( $tocList.length ) {
- if ( $tocList.is( ':hidden' ) ) {
- $tocList.slideDown( 'fast', callback );
- $toggleLink.text( mw.msg( 'hidetoc' ) );
- $( '#toc' ).removeClass( 'tochidden' );
- $.cookie( 'mw_hidetoc', null, {
- expires: 30,
- path: '/'
- } );
- return true;
- } else {
- $tocList.slideUp( 'fast', callback );
- $toggleLink.text( mw.msg( 'showtoc' ) );
- $( '#toc' ).addClass( 'tochidden' );
- $.cookie( 'mw_hidetoc', '1', {
- expires: 30,
- path: '/'
- } );
- return false;
- }
- } else {
+ if ( !$tocList.length ) {
return null;
}
+ if ( $tocList.is( ':hidden' ) ) {
+ $tocList.slideDown( 'fast', callback );
+ $toggleLink
+ .prop( 'aria-expanded', true )
+ .text( mw.msg( 'hidetoc' ) );
+ $( '#toc' ).removeClass( 'tochidden' );
+ $.cookie( 'mw_hidetoc', null, {
+ expires: 30,
+ path: '/'
+ } );
+ return true;
+ } else {
+ $tocList.slideUp( 'fast', callback );
+ $toggleLink
+ .prop( 'aria-expanded', false )
+ .text( mw.msg( 'showtoc' ) );
+ $( '#toc' ).addClass( 'tochidden' );
+ $.cookie( 'mw_hidetoc', '1', {
+ expires: 30,
+ path: '/'
+ } );
+ return false;
+ }
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/79053
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic493fe3ab38b0bca477a40db4eb420be875b2efa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
