jenkins-bot has submitted this change and it was merged.

Change subject: New Parsoid test: run parsoid's parserTests file using PHP 
parser.
......................................................................


New Parsoid test: run parsoid's parserTests file using PHP parser.

This helps ensure that we don't commit tests to our fork of
parserTests.txt that will break when we try to merge them with core.

Change-Id: I49d3551676893bfdf7fdf408e90d7477a33608a7
---
M parsoid.yaml
1 file changed, 36 insertions(+), 0 deletions(-)

Approvals:
  Subramanya Sastry: Looks good to me, but someone else must approve
  MarkTraceur: Looks good to me, approved
  GWicke: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/parsoid.yaml b/parsoid.yaml
index cdd15ab..c8e46a2 100644
--- a/parsoid.yaml
+++ b/parsoid.yaml
@@ -51,6 +51,41 @@
             files: '**/results.xml'
 
 - job-template:
+    name: parsoid-php-parsertests
+    node: hasSlaveScripts
+    wrappers:
+        - timeout:
+            timeout: 10
+            fail: true
+    defaults:
+        use-zuul
+    triggers:
+        - zuul
+    scm:
+        - git:
+            url: '/srv/ssd/zuul/git/mediawiki/extensions/Parsoid'
+            refspec: '$ZUUL_REF'
+            name: 'origin'
+            disable-submodules: true
+        - git:
+            url: 
'https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Parsoid/js/contrib.git'
+            branches:
+                - master
+            basedir: contrib
+        - git:
+            url: 'https://gerrit.wikimedia.org/r/p/mediawiki/core.git'
+            branches:
+                - master
+            basedir: core
+    builders:
+        # run our parserTests.txt file using core's php parser to ensure
+        # that non-parsoid only tests are actually correct wrt the PHP parser.
+        - shell: |
+            # If any of these commands fail, something is wrong
+            set -e
+            php core/tests/parserTests.php --color=no 
--file=js/tests/parserTests.txt --quiet
+
+- job-template:
     name: parsoid-parsertests
     node: hasSlaveScripts
     triggers:
@@ -252,3 +287,4 @@
         - parsoid-parse-tool-check
         - parsoid-roundtrip-test-check
         - parsoid-parsertests-run-harder
+        - parsoid-php-parsertests

-- 
To view, visit https://gerrit.wikimedia.org/r/79013
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I49d3551676893bfdf7fdf408e90d7477a33608a7
Gerrit-PatchSet: 1
Gerrit-Project: integration/jenkins-job-builder-config
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
Gerrit-Reviewer: GWicke <[email protected]>
Gerrit-Reviewer: Hashar <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: MarkTraceur <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to