jenkins-bot has submitted this change and it was merged.
Change subject: Regression: slightly wrong styling in uploads nag overlay
......................................................................
Regression: slightly wrong styling in uploads nag overlay
List elements there should have no bullet points.
Change-Id: Ib9b26d3829b8766a071d3e27c89516c9e2f51d5a
---
M less/modules/uploads.less
M stylesheets/modules/uploads.css
M templates/photoNag.html
3 files changed, 20 insertions(+), 14 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/less/modules/uploads.less b/less/modules/uploads.less
index 5214c50..bcbb359 100644
--- a/less/modules/uploads.less
+++ b/less/modules/uploads.less
@@ -93,6 +93,11 @@
}
}
+ // FIXME: this should not be necessary
+ ul {
+ list-style: none;
+ }
+
li {
clear: both;
min-height: @checkboxSize;
diff --git a/stylesheets/modules/uploads.css b/stylesheets/modules/uploads.css
index cab4e23..6505248 100644
--- a/stylesheets/modules/uploads.css
+++ b/stylesheets/modules/uploads.css
@@ -100,6 +100,9 @@
-webkit-background-size: 32px auto;
background-size: 32px auto;
}
+.photo-nag ul {
+ list-style: none;
+}
.photo-nag li {
clear: both;
min-height: 50px;
diff --git a/templates/photoNag.html b/templates/photoNag.html
index 705c81e..cfcc4af 100644
--- a/templates/photoNag.html
+++ b/templates/photoNag.html
@@ -3,18 +3,16 @@
</div>
<div class="photo-nag">
<div class="preview loading"></div>
- <div class="content">
- <ul>
- {{#nagMessages}}
- <li>
- <label>
- <div><input type="checkbox"></div>
- <strong>{{heading}}</strong>
- {{{text}}}
- </label>
- <button class="inline">{{learnMore}}</button>
- </li>
- {{/nagMessages}}
- </ul>
- </div>
+ <ul class="content">
+ {{#nagMessages}}
+ <li>
+ <label>
+ <div><input type="checkbox"></div>
+ <strong>{{heading}}</strong>
+ {{{text}}}
+ </label>
+ <button class="inline">{{learnMore}}</button>
+ </li>
+ {{/nagMessages}}
+ </ul>
</div>
--
To view, visit https://gerrit.wikimedia.org/r/76227
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9b26d3829b8766a071d3e27c89516c9e2f51d5a
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: JGonera <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
