Subramanya Sastry has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/79450


Change subject: Fix crasher introduced in commit 89057946294cc.
......................................................................

Fix crasher introduced in commit 89057946294cc.

* I was trying to update dsr in the wrong object!
* Fixes crasher in es:Siete_maravillas_naturales_del_mundo

Change-Id: Id56f9b00a1976a18ad8cb35b94a47b82b8cc51fd
---
M js/lib/dom.wrapTemplates.js
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/50/79450/1

diff --git a/js/lib/dom.wrapTemplates.js b/js/lib/dom.wrapTemplates.js
index b7be616..b5ae72c 100644
--- a/js/lib/dom.wrapTemplates.js
+++ b/js/lib/dom.wrapTemplates.js
@@ -736,13 +736,15 @@
                                                        tbl = tbl.nextSibling;
                                                }
 
-                                               var dp = 
sm.parentNode.data.parsoid;
+                                               var dp = 
DU.getDataParsoid(sm.parentNode);
                                                if (tbl &&
                                                        DU.hasNodeName(tbl, 
'table') &&
                                                        dp.fostered)
                                                {
-                                                       if (dp.tsr && dp.tsr[0] 
!== null && tbl.dsr[0] === null) {
-                                                               tbl.dsr[0] = 
dp.tsr[0];
+                                                       var tblDP = 
DU.getDataParsoid(tbl);
+                                                       if (dp.tsr && dp.tsr[0] 
!== null && tblDP.dsr[0] === null)
+                                                       {
+                                                               tblDP.dsr[0] = 
dp.tsr[0];
                                                        }
                                                        
tbl.setAttribute('about', about); // set about on elem
                                                        ee = tbl;

-- 
To view, visit https://gerrit.wikimedia.org/r/79450
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id56f9b00a1976a18ad8cb35b94a47b82b8cc51fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to